Add Support for VS 16.8 Which Introduced Breaking Changes#42
Merged
RehanSaeed merged 1 commit intomainfrom Nov 23, 2020
Merged
Conversation
RehanSaeed
added
enhancement
RehanSaeed
force-pushed
the
support-vs-16-8
branch
from
42269fe to
b677796
Compare
This was referenced Nov 17, 2020
RehanSaeed
added a commit
that referenced
this pull request
Dec 11, 2020
This reverts commit 4bf2cd6.
RehanSaeed
added a commit
that referenced
this pull request
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way you set the severity in .editorconfig files changed drastically in VS 16.8 and is a breaking change. On the positive side, we now get errors/warnings in CI builds. I've set a default severity of warning like so:
Then added custom severities of suggestion where necessary. This requires knowing the error code which is a little opaque from our point of view where we are editing the .editorconfig file directly but when using VS, it's quite apparent from the error list.
Furthermore, I've updated
dotnet_style_parentheses_in_other_operatorstoalways_for_clarity. The other parenthesis settings do the same and I'm not sure why we had it the opposite way around.