Delete duplicate command filter registration#447
Merged
tezc merged 1 commit intoRedisLabs:masterfrom Jul 11, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
==========================================
- Coverage 54.99% 54.96% -0.03%
==========================================
Files 37 37
Lines 13324 13323 -1
Branches 1537 1537
==========================================
- Hits 7327 7323 -4
- Misses 5997 6000 +3
Continue to review full report at Codecov.
|
fadidahanna
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced by #360, the command filter will be registered twice as part of a rebase mistake. It is harmless but unnecessary. Also, as we are not using the command filter object itself, we don't need to keep a reference to it.