Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 53.14% 54.70% +1.55%
==========================================
Files 37 37
Lines 13513 13284 -229
Branches 1627 1532 -95
==========================================
+ Hits 7182 7267 +85
+ Misses 6331 6017 -314 ☔ View full report in Codecov by Sentry. |
fadidahanna
reviewed
Jun 9, 2022
fadidahanna
reviewed
Jun 12, 2022
Contributor
|
|
yossigo
reviewed
Jun 15, 2022
Collaborator
Author
|
Updated PR, not using module args anymore. |
fadidahanna
reviewed
Jun 19, 2022
fadidahanna
previously approved these changes
Jun 19, 2022
fadidahanna
approved these changes
Jun 30, 2022
This was referenced Jul 4, 2022
Merged
tezc
added a commit
that referenced
this pull request
Jul 11, 2022
Delete duplicate command filter registration Introduced by #360, the command filter will be registered twice as part of a rebase mistake. It is harmless but unnecessary. Also, as we are not using the command filter object itself, we don't need to keep a reference to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RedisRaft adopts new configuration API: redis/redis#10285
After this commit,
RAFT.CONFIGwill not exist anymore.CONFIGcommand will be used instead.Usage:
config set raft.addr 127.0.0.1:8000andconfig get raft.id./redis-server --port 5001 --loadmodule redisraft.so --raft.id 3 --raft.addr 127.0.0.1:8000Breaking changes
CONFIGcommand will be used instead ofRAFT.CONFIGConfiguration parameters will require
raft.or--raft.prefix.Renamed some configuration parameters:
Reasoning: As all parameters now have
raft.prefix, parameters already starting withraftwould include too many "raft"s :). With this change, instead ofraft.raft-log-fsync, we'll haveraft.log-fsync.join-timeoutconfig was in seconds. Now, it is in milliseconds.connection-timeoutconfig was in microseconds. Now, it is in milliseconds.Reasoning: Now, all timeout configs are in milliseconds. I suggest keeping it that way for future configuration parameters as well. This is easy to remember and it prevents confusion.
Jepsen part: RedisLabs/jepsen-redisraft#3
Closes: #306