MOD-11358 integrate ijson to the json module (#1394)#1414
Merged
AvivDavid23 merged 1 commit into8.4from Oct 15, 2025
Merged
Conversation
* initial, but tests fails * change all to clone for testing * Revert "change all to clone for testing" This reverts commit 5af50a4. * Revert "Revert "change all to clone for testing"" This reverts commit 852a223. * Revert "Revert "Revert "change all to clone for testing""" This reverts commit 4252d45. * complies, tests are failing * better macro * debug * fix values set for arrays * Revert "debug" This reverts commit d3e8e5518fea0aa0fcde5e781f7f68c9bffbc1ea. * remove print * Revert "Revert "debug"" This reverts commit 3056dfc5b907eca917267dee636facfcfab82102. * fix tests * Revert "Revert "Revert "debug""" This reverts commit cd40fd7aa2db86ca51e82a0604f215f8fbcc5ade. * c_api impl * cargo fmt * register c_api ver 6 * add another test * test * fix * more coverage * more coverage * more coverage * test also integer + float numerics * remove get_at c api * bump ijson * update c_api * fix * CR * cargo fmt * c_api * fmt * free data * c_api * header fix * cr * add benchmark * c_api * refine test * refine test * add json_api_get_value_from_ptr * fix c_api * fmt * fix bench * move is_equal of select values * fix (cherry picked from commit 9a5f051)
gabsow
approved these changes
Oct 15, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.4 #1414 +/- ##
==========================================
- Coverage 79.28% 78.09% -1.19%
==========================================
Files 15 16 +1
Lines 3707 3908 +201
==========================================
+ Hits 2939 3052 +113
- Misses 768 856 +88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial, but tests fails
change all to clone for testing
Revert "change all to clone for testing"
This reverts commit 5af50a4.
This reverts commit 852a223.
This reverts commit 4252d45.
complies, tests are failing
better macro
debug
fix values set for arrays
Revert "debug"
This reverts commit d3e8e5518fea0aa0fcde5e781f7f68c9bffbc1ea.
remove print
Revert "Revert "debug""
This reverts commit 3056dfc5b907eca917267dee636facfcfab82102.
fix tests
Revert "Revert "Revert "debug"""
This reverts commit cd40fd7aa2db86ca51e82a0604f215f8fbcc5ade.
c_api impl
cargo fmt
register c_api ver 6
add another test
test
fix
more coverage
more coverage
more coverage
test also integer + float numerics
remove get_at c api
bump ijson
update c_api
fix
CR
cargo fmt
c_api
fmt
free data
c_api
header fix
cr
add benchmark
c_api
refine test
refine test
add json_api_get_value_from_ptr
fix c_api
fmt
fix bench
move is_equal of select values
fix
(cherry picked from commit 9a5f051)
Note
Introduce ValueRef-based zero-copy traversal, add typed numeric array operations, and update the C API to v6 with alloc/free and revised accessors.
ValueRef(borrowed/owned) acrossSelectValue, iterators (values,items,get_key,get_index) and path eval; add helper macros for handling owned/borrowed.PathCalculator, filter evaluation, and outputs to useValueRef; adjust public APIs (calc,calc_once, with-path variants) accordingly.ARRAPPEND/ARRINSERT/ARRTRIM, numeric ops) via newPathValuehandling.ValueRef(e.g.,Values,KeyValue, equality moved toselect_value::is_equal).allocJson/freeJsonand changegetAt/nextKeyValueto fill a provided pointer; update iterators and wrappers; export API version 6.rejson_api.hwithRedisJSONPtrand new function signatures; deprecate old pointer-returninggetAt.ijsonrev; addhalf,paste,crunchy.Written by Cursor Bugbot for commit c77a28d. This will update automatically on new commits. Configure here.