Skip to content

MOD-10709 pin nightly version#1375

Merged
ephraimfeldblum merged 3 commits intomasterfrom
ephraim_pin-nightly-version
Aug 13, 2025
Merged

MOD-10709 pin nightly version#1375
ephraimfeldblum merged 3 commits intomasterfrom
ephraim_pin-nightly-version

Conversation

@ephraimfeldblum
Copy link
Contributor

@ephraimfeldblum ephraimfeldblum commented Aug 5, 2025

@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.68%. Comparing base (c94ee01) to head (c59b139).
⚠️ Report is 47 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1375      +/-   ##
==========================================
+ Coverage   78.37%   78.68%   +0.31%     
==========================================
  Files          15       15              
  Lines        4004     3678     -326     
==========================================
- Hits         3138     2894     -244     
+ Misses        866      784      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ephraimfeldblum ephraimfeldblum requested a review from eranhd August 5, 2025 10:36
@ephraimfeldblum ephraimfeldblum merged commit b3297ec into master Aug 13, 2025
20 checks passed
@ephraimfeldblum ephraimfeldblum deleted the ephraim_pin-nightly-version branch August 13, 2025 14:21
@gdesmott
Copy link

I think you also need to specify the pinned nightly version in Makefile: https://github.com/RedisJSON/RedisJSON/blob/master/Makefile#L112

I workaround it in the RediSearch CI by using the RUST_GOOD_NIGHTLY env variable, see https://github.com/RediSearch/RediSearch/pull/6513/files , but it would be good to fix that there at some point as well.

@eranhd
Copy link
Collaborator

eranhd commented Aug 21, 2025

I think you also need to specify the pinned nightly version in Makefile: https://github.com/RedisJSON/RedisJSON/blob/master/Makefile#L112

I workaround it in the RediSearch CI by using the RUST_GOOD_NIGHTLY env variable, see https://github.com/RediSearch/RediSearch/pull/6513/files , but it would be good to fix that there at some point as well.

@ephraimfeldblum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants