RI-5917-ShowTTL-checkbox-for-hash-fields #3624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsergeenko
reviewed
Jul 22, 2024
| import { EuiButton, EuiCheckbox, EuiFlexGroup, EuiFlexItem } from '@elastic/eui' | ||
| import AutoSizer from 'react-virtualized-auto-sizer' | ||
|
|
||
| import VerticalDivider from 'uiSrc/pages/rdi/statistics/components/vertical-divider' |
There was a problem hiding this comment.
I do not recommend using here VerticalDivider from rdi statistics components, could you please change it to Divider from common components? Maybe add property to have an ability use vertical
| {({ width = 0 }) => ( | ||
| <div style={{ width }}> | ||
| <EuiFlexGroup justifyContent="flexEnd"> | ||
| <EuiFlexItem className={styles.keyFormatter__item}> |
There was a problem hiding this comment.
no reason use BEM since we use scoped styles,
it is better to name keyFormatterItem
rsergeenko
previously approved these changes
Jul 22, 2024
…RI-5917-hide-ttl-for-individual-hash-fields
…are-not-aligned RI-5960 fixed borders are not aligned
…-checkbox-not-work RI-5959 fixed showttl not working
…individual-hash-fields' into e2e/feature/RI-5917-hide-ttl-for-individual-hash-fields
…l-for-individual-hash-fields
…dividual-hash-fields
kchepikava
requested review from
ViktarStarastsenka and
ArtemHoruzhenko
as code owners
egor-zalenski
previously approved these changes
Jul 29, 2024
… into e2e/feature/RI-5917-hide-ttl-for-individual-hash-fields
…tl-for-individual-hash-fields E2e/feature/ri 5917 hide ttl for individual hash fields
|
@romansergeenkosofteq, last commit adds subheader to all types |
rsergeenko
previously approved these changes
Jul 30, 2024
rsergeenko
previously approved these changes
Jul 30, 2024
kchepikava
dismissed
rsergeenko’s stale review
The merge-base changed after approval.
kchepikava
requested review from
rsergeenko
and removed request for
ArtemHoruzhenko and
ViktarStarastsenka
|
@romansergeenkosofteq, this needs to be reapproved in order to be merged |
rsergeenko
approved these changes
Aug 6, 2024
mariasergeenko
deleted the
fe/feature/RI-5917-hide-ttl-for-individual-hash-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#RI-5917