Conversation
| void ExecutionPlan_Print(const ExecutionPlan *plan, RedisModuleCtx *ctx) { | ||
| ASSERT(plan && ctx); | ||
|
|
||
| if(ErrorCtx_EncounteredError()) return; |
There was a problem hiding this comment.
Please remove.
In cmd_explain.c
ExecutionPlan_PreparePlan(plan);
ExecutionPlan_Init(plan); // Initialize the plan's ops.
if(ErrorCtx_EncounteredError()) {
ErrorCtx_EmitException();
goto cleanup;
}
ExecutionPlan_Print(plan, ctx); // Print the execution plan.
cleanup:There was a problem hiding this comment.
why?
every time calling to ExecutionPlan_Print it is needed
There was a problem hiding this comment.
this is mixing boundaries, it is preferred that the execution-plan won't be aware of ErrorCtx,
also it seems weird that a call made to ExecutionPlan_PreparePlan won't print anything...
|
@AviAvni tests fail due to |
Codecov Report
@@ Coverage Diff @@
## master #1950 +/- ##
==========================================
+ Coverage 91.90% 92.65% +0.74%
==========================================
Files 239 239
Lines 20372 20373 +1
==========================================
+ Hits 18723 18876 +153
+ Misses 1649 1497 -152
Continue to review full report at Codecov.
|
* print plan only if no errors * address review and fix tests * update redisgraph version * return error on profile * add tests * add comment * Update cmd_query.c Co-authored-by: Roi Lipman <[email protected]>
2 participants
No description provided.