Closed
Conversation
* Fix flawed assertion in index deletion logic * Reduce KPI for updates_baseline benchmark * Address PR comments * Address PR comments Co-authored-by: Roi Lipman <[email protected]>
* Always report run-time errors as the sole reply * Update test_timeout.py Co-authored-by: Roi Lipman <[email protected]>
swilly22
force-pushed
the
multi-label-node
branch
from
a2cd44e to
6199288
Compare
(cherry picked from commit 79c2edf)
swilly22
reviewed
Sep 30, 2021
Contributor
swilly22
left a comment
swilly22
left a comment
There was a problem hiding this comment.
Make sure we test QGNode such that it is impossible to create a QGNode with a duplicated label
e.g. MATCH (a:A:B:A) should create a QueryGraphNode with just A and B labels
jeffreylovitz
commented
Sep 30, 2021
| AlgebraicExpression *ae_src = AlgebraicExpression_RemoveSource(&exps[0]); | ||
| ASSERT(AlgebraicExpression_DiagonalOperand(ae_src, 0)); | ||
|
|
||
| const char *label = AlgebraicExpression_Label(ae_src); |
Contributor
Author
There was a problem hiding this comment.
👍 This is a much nicer solution, good idea!
swilly22
reviewed
Oct 1, 2021
| @@ -5,21 +5,21 @@ | |||
| */ | |||
|
|
|||
| #include "bulk_insert.h" | |||
Contributor
There was a problem hiding this comment.
Please add tests for bulk loading multi-label nodes
swilly22
previously approved these changes
Oct 12, 2021
Contributor
|
Closed for #1988 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces support for multiple labels on nodes in querying and data persistence.
One element that is absent from this PR is a heuristic for determining which label operand is the best candidate for being used as the LabelScan entry-point. The sensible rule for this would be to defer to usable indexes, and that failing choose the label with the fewest associated nodes, but we don't currently have access to label matrices when these choices are being made.