Skip to content

Commit acde693

Browse files
authored
Multi-platform build, take 2 (#1598)
1 parent 26ace7a commit acde693

File tree

3 files changed

+27
-12
lines changed

3 files changed

+27
-12
lines changed

.circleci/config.yml

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -130,14 +130,14 @@ commands:
130130
name: Build for platform
131131
command: |
132132
cd build/docker
133-
make build OSNICK=<<parameters.platform>> X64=1 ARTIFACTS=1 TEST=1 SHOW=1
133+
make build OSNICK=<<parameters.platform>> ARTIFACTS=1 TEST=1 SHOW=1
134134
- early_return_for_forked_pull_requests
135135
- run:
136136
name: Build for platform (publish)
137137
command: |
138138
docker login -u redisfab -p $DOCKER_REDISFAB_PWD
139139
cd build/docker
140-
make publish OSNICK=<<parameters.platform>> X64=1 SHOW=1
140+
make publish OSNICK=<<parameters.platform>> OFFICIAL=0 SHOW=1 VERBOSE=1
141141
- persist_to_workspace:
142142
root: bin/artifacts
143143
paths:
@@ -158,15 +158,12 @@ jobs:
158158
- checkout
159159
- setup-prerequisits
160160
- load-cached-deps
161-
162161
- run:
163162
name: Build
164163
command: |
165164
make
166165
make package
167-
168166
- save-deps-cache
169-
170167
- run:
171168
name: Test
172169
command: make test
@@ -184,7 +181,6 @@ jobs:
184181
- load-cached-deps
185182
- attach_workspace:
186183
at: /workspace
187-
188184
- run:
189185
name: Test for memory leaks
190186
command: |
@@ -207,10 +203,19 @@ jobs:
207203
- setup-prerequisits
208204
- run:
209205
name: Build
210-
command: make
206+
command: |
207+
make
208+
make package
211209
- run:
212210
name: Test
213211
command: make test
212+
- persist_to_workspace:
213+
root: bin/artifacts
214+
paths:
215+
- 'snapshots/*.zip'
216+
- 'snapshots/*.tgz'
217+
- '*.zip'
218+
- '*.tgz'
214219

215220
platform_build:
216221
parameters:
@@ -233,7 +238,7 @@ jobs:
233238
command: |
234239
du -ah --apparent-size artifacts/snapshots/*
235240
for f in artifacts/snapshots/*.zip artifacts/snapshots/*.tgz; do
236-
echo aws s3 cp $f s3://redismodules/$PACKAGE_NAME/snapshots/ --acl public-read
241+
aws s3 cp $f s3://redismodules/$PACKAGE_NAME/snapshots/ --acl public-read
237242
done
238243
239244
deploy_release:
@@ -247,7 +252,7 @@ jobs:
247252
command: |
248253
du -ah --apparent-size artifacts/*
249254
for f in artifacts/*.zip artifacts/*.tgz; do
250-
echo aws s3 cp $f s3://redismodules/$PACKAGE_NAME/ --acl public-read
255+
aws s3 cp $f s3://redismodules/$PACKAGE_NAME/ --acl public-read
251256
done
252257
253258
release_automation:
@@ -272,7 +277,7 @@ jobs:
272277

273278
performance_ci_automation:
274279
docker:
275-
- image: 'redisfab/rmbuilder:6.0.9-x64-bionic'
280+
- image: redisfab/rmbuilder:6.0.9-x64-bionic
276281
steps:
277282
- early_return_for_forked_pull_requests
278283
- checkout
@@ -282,7 +287,7 @@ jobs:
282287

283288
nightly_performance_automation:
284289
docker:
285-
- image: 'redisfab/rmbuilder:6.0.9-x64-bionic'
290+
- image: redisfab/rmbuilder:6.0.9-x64-bionic
286291
steps:
287292
- early_return_for_forked_pull_requests
288293
- checkout
@@ -298,6 +303,7 @@ jobs:
298303
- benchmark-automation:
299304
github_actor: "ci.nightly"
300305

306+
301307
on-any-branch: &on-any-branch
302308
filters:
303309
branches:
@@ -373,6 +379,7 @@ workflows:
373379
- deploy_branch:
374380
requires:
375381
- platform_build
382+
- build_macos
376383
<<: *on-integ-branch
377384
- release_automation:
378385
requires:
@@ -381,6 +388,7 @@ workflows:
381388
<<: *on-version-tags
382389
requires:
383390
- platform_build
391+
- build_macos
384392
- performance_ci_automation:
385393
<<: *on-integ-branch
386394
requires:

Dockerfile

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,18 @@ COPY --from=redis /usr/local/ /usr/local/
3131
ADD ./ /build
3232

3333
# Set up a build environment
34+
RUN if [ ! -d ./deps/readies ]; then \
35+
mkdir -p deps ;\
36+
cd deps ;\
37+
git clone https://github.com/RedisLabsModules/readies.git ;\
38+
fi
3439
RUN ./deps/readies/bin/getpy3
3540
RUN ./sbin/system-setup.py
3641

3742
RUN if [ ! -z $(command -v apt-get) ]; then \
3843
locale-gen --purge en_US.UTF-8 ;\
3944
dpkg-reconfigure -f noninteractive locales ;\
40-
fi
45+
fi
4146

4247
ENV LANG=en_US.UTF-8
4348
ENV LANGUAGE=en_US.UTF-8

build/docker/Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ OSNICK ?= buster
88

99
REPO=redisgraph
1010

11+
INT_BRANCHES=2.2 2.0 1.2 1.0
12+
1113
ART_DIR=$(ROOT)/bin/artifacts
1214
ART_INT_DIR=/var/opt/redislabs/artifacts
1315

0 commit comments

Comments
 (0)