Merge master to 1.2 by MeirShpilraien · Pull Request #702 · RedisGears/RedisGears

MeirShpilraien · 2022-01-31T17:54:16Z

No description provided.

This is not yet wired up to CI

Fix leak in redisAI.tensorToFlatList method

* Fix valgrind failure on Redis 6.2 * More fixes

* added json example to docs * added json-avg.py * Update examples.md Co-authored-by: Guy Korland <[email protected]>

* fix unstable test * initialize runId to NULL * increase max idle time to avoid failures on mac * Fix tests

* fix unstable valgrind test * review fixes

#575)

* Add null record type * make NullRecord singelton * remove special record * init NullRecord * update apis * make NullRecord a special record * rename IS_SPECIAL_RECORD to IS_SINGLETON

sonatype-lift · 2022-01-31T17:56:47Z

pytest/test_network.py


    def __enter__(self):
-        self.stream_server = gevent.server.StreamServer(('localhost', 10000), self._handle_conn)
+        self.port = random.randint(10000,20000)


blacklist: Standard pseudo-random generators are not suitable for security/cryptographic purposes.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:48Z

plugins/jvmplugin/pytest/test_register.py

+                counter = conn.get('counter')
+                time.sleep(0.1)
+            env.assertTrue(False, message='Counter reached 3 while not expected')
+    except Exception as e:


try_except_pass: Try, Except, Pass detected.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:49Z

docs/snippets/async_await/async_await-000.py

+async def coro(r):
+	await asyncio.sleep(5)
+
+GB('ShardsIDReader').foreach(coro).run()


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:50Z

docs/snippets/async_await/async_await-001.py

+    global mutex
+    mutex = MyMutex()
+
+GB('CommandReader').map(publish).register(trigger='MSG_PUBLISH')


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:51Z

docs/snippets/async_await/async_await-002.py

+    global mutex
+    mutex = MyMutex()
+
+GB('CommandReader').map(publish).register(trigger='MSG_PUBLISH1')


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:53Z

docs/snippets/async_await/async_await-003.py

+	execute('set', 's_count{%s}' % hashtag(), c, 'EX', '5')
+	return c
+
+GB('CommandReader').map(CountStudents).register(trigger='COUNT_STUDENTS', mode='async_local')


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:54Z

docs/snippets/async_await/async_await-004.py

+		return c
+	return AsyncCountStudents()
+
+GB('CommandReader').map(CountStudents).register(trigger='COUNT_STUDENTS1', mode='sync')


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:55Z

docs/snippets/command_hook/command_hook-000.py

+    new_args = r[1:] + ['_last_modified_', t]
+    return call_next(*new_args)
+
+GB('CommandReader').map(my_hset).register(hook='hset', mode='sync')


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:56Z

docs/snippets/command_hook/command_hook-001.py

+    execute('hincrby', r[1], '_times_modified_', 1)
+    return call_next(*r[1:])
+
+GB('CommandReader').map(my_hset).register(hook='hset', mode='sync')


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:57Z

docs/snippets/command_hook/command_hook-002.py

+    new_args = r[1:] + ['_last_modified_', t]
+    return call_next(*new_args)
+
+GB('CommandReader').map(my_hset).register(hook='hset', keyprefix='person', mode='sync')


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:56:58Z

docs/snippets/examples/json-avg.py

@@ -0,0 +1,7 @@
+import json
+
+gb = GB()


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:57:00Z

docs/snippets/examples/json-avg.py

+import json
+
+gb = GB()
+gb.map(lambda r: json.loads(execute('json.get', r['key'], '$'))) # read the json


Unbound name: Name execute is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:57:01Z

docs/snippets/intro/intro-008-1.py

+    execute('SET', k, x)  # set key to new value
+
+# Event handling function registration
+gb = GearsBuilder()


Unbound name: Name GearsBuilder is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:57:02Z

docs/snippets/miss_event/miss_event-000.py

@@ -0,0 +1 @@
+GB().foreach(lambda x: log('key %s was fetched and missed' % x['key'])).register(eventTypes=['keymiss'], mode="async_local")


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:57:04Z

docs/snippets/miss_event/miss_event-000.py

@@ -0,0 +1 @@
+GB().foreach(lambda x: log('key %s was fetched and missed' % x['key'])).register(eventTypes=['keymiss'], mode="async_local")


Unbound name: Name log is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:57:05Z

docs/snippets/miss_event/miss_event-001.py

+    data = conn.get(key)
+    execute('set', key, data)
+
+GB().foreach(fetch_data).register(eventTypes=['keymiss'], mode="async_local")


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

sonatype-lift · 2022-01-31T17:57:06Z

docs/snippets/miss_event/miss_event-002.py

+    execute('set', key, data)
+    override_reply(data)
+
+GB().foreach(fetch_data).register(commands=['get'], eventTypes=['keymiss'], mode="async_local")


Unbound name: Name GB is used but not defined in the current scope.
(at-me in a reply with help or ignore)

lgtm-com · 2022-01-31T18:10:21Z

This pull request introduces 2 alerts when merging 93e6bf7 into 1fd850c - view on LGTM.com

new alerts:

1 for Unused import
1 for Variable defined multiple times

This reverts commit d32b261.

Meir Shpilraien (Spielrein) and others added 30 commits February 11, 2021 11:08

Fix crash on cluster set from shard (#506)

c792079

Fix bad test (#510)

0910c95

use mkdocs-modules-template (#516)

17b9f5a

upgrade mkdocs & mkdocs-material (#517)

bb7247d

adding gmake4 to centos7 for RedisGears

02c6122

This is not yet wired up to CI

Decrease ref count of value after appending it to list

9396ca8

Merge pull request #523 from RedisGears/Fix_leak_in_tensorToFlatList

130f9db

Fix leak in redisAI.tensorToFlatList method

Moved to Redis 6.2 (#519)

fc57a85

Fix valgrind failure on Redis 6.2 (#526)

c9af973

* Fix valgrind failure on Redis 6.2 * More fixes

Merge branch 'master' into ck-centos7-mastered

6e03f8c

Merge pull request #520 from RedisGears/ck-centos7-mastered

b160b4c

Build updates (#530)

ed10294

Add json example (#540)

d35c5f1

* added json example to docs * added json-avg.py * Update examples.md Co-authored-by: Guy Korland <[email protected]>

Added redgrease as client library to the docs (#543)

a2fda83

fix unstable test (#544)

572478f

* fix unstable test * initialize runId to NULL * increase max idle time to avoid failures on mac * Fix tests

Update config.yml (#547)

91f136c

make platform + build/docker REDIS_VER (#548)

3ffe496

fix #554, fix config get to return user defined config (#557)

8e6451c

Avoid warnings from redisgears.h (#555)

dda7058

fix unstable valgrind test (#556)

de5e3b0

* fix unstable valgrind test * review fixes

early returns (#559)

a0e94cd

updating to redis 6.2.4 (#567)

96773c2

Added QA automation tests (#531)

2138c7f

Build system changes (#571)

eac15db

Lock Redis GIL when creating RedisAI DAG from string (#572)

441beeb

build/docker repo name fix (#573)

ebc483f

removing docker curl and executing, relying on the contents of github… (

74f40f7

#575)

Add null record type (#578)

4202fb2

* Add null record type * make NullRecord singelton * remove special record * init NullRecord * update apis * make NullRecord a special record * rename IS_SPECIAL_RECORD to IS_SINGLETON

Change package name scheme (#579)

4a69b83

release drafter and release actions (#583)

ddfa60d

meir added 4 commits January 31, 2022 19:48

Merge branch 'master' into merge_master_to_1.2

157c19b

set version to 1.2.2

8eee104

set gears_runtime version to 1.0.0

ce3943a

added rg.jdumpsessions to ramp

93e6bf7

MeirShpilraien requested a review from gkorland January 31, 2022 17:54

sonatype-lift bot reviewed Jan 31, 2022

View reviewed changes

gkorland approved these changes Jan 31, 2022

View reviewed changes

gkorland merged commit d32b261 into 1.2 Jan 31, 2022

gkorland deleted the merge_master_to_1.2 branch January 31, 2022 19:14

MeirShpilraien pushed a commit that referenced this pull request Jan 31, 2022

Revert "Merge master to 1.2 (#702)"

dce855d

This reverts commit d32b261.

gkorland pushed a commit that referenced this pull request Jan 31, 2022

Revert "Merge master to 1.2 (#702)" (#704)

5bfbe5c

This reverts commit d32b261.

chayim mentioned this pull request Apr 18, 2022

Version jvmplugin from the version passed in #756

Merged

chayim mentioned this pull request Aug 21, 2022

disable hirsute #816

Merged

		@@ -0,0 +1 @@
		GB().foreach(lambda x: log('key %s was fetched and missed' % x['key'])).register(eventTypes=['keymiss'], mode="async_local") No newline at end of file

Conversation

MeirShpilraien commented Jan 31, 2022

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

sonatype-lift bot Jan 31, 2022

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Jan 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants