Fix #558, wait for cluster to be initialized when reading stream data(#656)#659
Merged
MeirShpilraien merged 1 commit into1.0from Jan 10, 2022
Merged
Fix #558, wait for cluster to be initialized when reading stream data(#656)#659MeirShpilraien merged 1 commit into1.0from
MeirShpilraien merged 1 commit into1.0from
Conversation
…#656) On oss cluster, if cluster is not initialized, read commands will failed and return an error. On stream reader, we assert that we read the stream successfully, such assertion will failed on uninitialized cluster and will cause a crash. Solution: 1. Before start scaning for streams, wait for cluster to be initialized. 2. '1' is not enough, by the time we find a stream to read the cluster might get uninitialized again. To solve this, if we failed to read the stream we retry after 5 seconds. We retry up to 10 times and than abort. (cherry picked from commit fb9f1cc)
chayim
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On oss cluster, if cluster is not initialized, read commands will failed and return an error. On stream reader, we assert that we read the stream successfully, such assertion will failed on uninitialized cluster and will cause a crash.
Solution:
(cherry picked from commit fb9f1cc)