Fix MOD-8194, initialize lookup table on rdbload.#827
Merged
MeirShpilraien merged 3 commits intomasterfrom Dec 10, 2024
Merged
Conversation
eranhd
reviewed
Dec 9, 2024
|
|
||
| /* Initialize lookupTable */ | ||
| for (uint32_t i = 0; i < TOPK_DECAY_LOOKUP_TABLE; ++i) { | ||
| topk->lookupTable[i] = pow(topk->decay, i); |
Contributor
There was a problem hiding this comment.
@MeirShpilraien can we build a shared lookup table mechanism to reduce the memory overhead here?
Author
There was a problem hiding this comment.
We probably can but it is out of the scope of this fix, the goal here is to fix a bug :)
eranhd
previously approved these changes
Dec 9, 2024
eranhd
reviewed
Dec 9, 2024
Contributor
eranhd
left a comment
eranhd
left a comment
There was a problem hiding this comment.
you tests fails on valgrind
eranhd
approved these changes
Dec 10, 2024
MeirShpilraien
deleted the
meir_MOD-8194_initialize_lookupTable_on_rdbload
branch
eranhd
pushed a commit
that referenced
this pull request
Dec 30, 2024
Fix MOD-8194, initialize lookup table on rdbload. (cherry picked from commit 306a748)
eranhd
pushed a commit
that referenced
this pull request
Dec 30, 2024
Fix MOD-8194, initialize lookup table on rdbload. (cherry picked from commit 306a748)
eranhd
pushed a commit
that referenced
this pull request
Dec 30, 2024
Fix MOD-8194, initialize lookup table on rdbload. (cherry picked from commit 306a748)
eranhd
pushed a commit
that referenced
this pull request
Dec 30, 2024
Fix MOD-8194, initialize lookup table on rdbload. (cherry picked from commit 306a748)
eranhd
added a commit
that referenced
this pull request
Jan 8, 2025
* Fix MOD-8194, initialize lookup table on rdbload. (#827) Fix MOD-8194, initialize lookup table on rdbload. (cherry picked from commit 306a748) * Fix MOD-8193, open key for write on CMS.INCRBY. (#828) Fix MOD-8193 Fix `CMS.INCRBY` to open the key for write. Open the key for read prevent it from invalidate a multi exec transaction if used with `watch` or when used with client side caching. (cherry picked from commit 5191cd1) --------- Co-authored-by: Meir Shpilraien (Spielrein) <[email protected]>
eranhd
added a commit
that referenced
this pull request
Jan 8, 2025
* Fix MOD-8194, initialize lookup table on rdbload. (#827) Fix MOD-8194, initialize lookup table on rdbload. (cherry picked from commit 306a748) * Fix MOD-8193, open key for write on CMS.INCRBY. (#828) Fix MOD-8193 Fix `CMS.INCRBY` to open the key for write. Open the key for read prevent it from invalidate a multi exec transaction if used with `watch` or when used with client side caching. (cherry picked from commit 5191cd1) --------- Co-authored-by: Meir Shpilraien (Spielrein) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.