[MOD-10926] Expose SVS Marked Deleted Vector Count via Statistics API#796
Merged
[MOD-10926] Expose SVS Marked Deleted Vector Count via Statistics API#796
Conversation
rename chnages_num -> num_marked_deleted to emphasize it onluy counts deletions SVSIndexBase: move num_marked_deleted to SVSIndexBase so it can be simply fetched without complex cast add getNumMarkedDeleted to API add virtual getNumMarkedDeleted to tiered index to be called by VecSimTieredIndex::statisticInfo hnsw tiered implmnetaion: call hnsw->VecSimIndexTombstone::getNumMarkedDeleted, (hnsw inhrits VecSimIndexTombstone) svs imp: returns SVSIndexBase::getNumMarkedDeleted
meiravgri
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 96.66% 96.64% -0.03%
==========================================
Files 126 126
Lines 7707 7712 +5
==========================================
+ Hits 7450 7453 +3
- Misses 257 259 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
approved these changes
Oct 13, 2025
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-796-to-8.2 origin/8.2
cd .worktree/backport-796-to-8.2
git switch --create backport-796-to-8.2
git cherry-pick -x 1c0ec77b9ce802a5023f376fcdebf824dc79c64b |
meiravgri
added a commit
that referenced
this pull request
Oct 13, 2025
…#796) SVSIndex rename chnages_num -> num_marked_deleted to emphasize it onluy counts deletions SVSIndexBase: move num_marked_deleted to SVSIndexBase so it can be simply fetched without complex cast add getNumMarkedDeleted to API add virtual getNumMarkedDeleted to tiered index to be called by VecSimTieredIndex::statisticInfo hnsw tiered implmnetaion: call hnsw->VecSimIndexTombstone::getNumMarkedDeleted, (hnsw inhrits VecSimIndexTombstone) svs imp: returns SVSIndexBase::getNumMarkedDeleted (cherry picked from commit 1c0ec77)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
…cs API (#797) [MOD-10926] Expose SVS Marked Deleted Vector Count via Statistics API (#796) SVSIndex rename chnages_num -> num_marked_deleted to emphasize it onluy counts deletions SVSIndexBase: move num_marked_deleted to SVSIndexBase so it can be simply fetched without complex cast add getNumMarkedDeleted to API add virtual getNumMarkedDeleted to tiered index to be called by VecSimTieredIndex::statisticInfo hnsw tiered implmnetaion: call hnsw->VecSimIndexTombstone::getNumMarkedDeleted, (hnsw inhrits VecSimIndexTombstone) svs imp: returns SVSIndexBase::getNumMarkedDeleted (cherry picked from commit 1c0ec77)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR exposes the number of marked deleted vectors in SVS through the
VecSimIndexStatsInfo.numberOfMarkedDeletedfield.Key Changes:
Added virtual
getNumMarkedDeleted()method to tiered index interfacehnsw->VecSimIndexTombstone::getNumMarkedDeleted()(HNSW inherits fromVecSimIndexTombstone)SVSIndexBase::getNumMarkedDeleted()VecSimTieredIndex::statisticInfo(): Now callsthis->getNumMarkedDeleted()instead of using complex dynamic castingAdditional changes
Better marked deleted interface for SVS:
changes_num→num_marked_deletedinSVSIndexto emphasize it only counts deletionsnum_marked_deletedfromSVSIndextoSVSIndexBasefor easier accessgetNumMarkedDeleted()method toSVSIndexBaseAPIgetNumMarkedDeleted()method to tiered index interface