Conversation
… in svs tired index
…_THRESHOLD` * Exposed `SVS_VAMANA_DEFAULT_UPDATE_THRESHOLD` to `vec_sim_common.h` to allow usage in RedisSearch.
meiravgri
changed the title
meiravgri
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
+ Coverage 96.66% 96.68% +0.01%
==========================================
Files 126 126
Lines 7707 7714 +7
==========================================
+ Hits 7450 7458 +8
+ Misses 257 256 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
reviewed
Oct 13, 2025
Collaborator
alonre24
left a comment
alonre24
left a comment
There was a problem hiding this comment.
Nice, one cosmetic suggestion
alonre24
approved these changes
Oct 13, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
… non- compressed svs tired index (#795) * use updateTriggerThreshold for training TH for non- compression index in svs tired index * * Renamed `SVS_DEFAULT_UPDATE_THRESHOLD` → `SVS_VAMANA_DEFAULT_UPDATE_THRESHOLD` * Exposed `SVS_VAMANA_DEFAULT_UPDATE_THRESHOLD` to `vec_sim_common.h` to allow usage in RedisSearch. * fix test * apply review suggetion (cherry picked from commit 4f58e35)
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
…TH for non- compressed svs tired index (#798) * [MOD-11784] [MOD-11785] use updateTriggerThreshold as training TH for non- compressed svs tired index (#795) * use updateTriggerThreshold for training TH for non- compression index in svs tired index * * Renamed `SVS_DEFAULT_UPDATE_THRESHOLD` → `SVS_VAMANA_DEFAULT_UPDATE_THRESHOLD` * Exposed `SVS_VAMANA_DEFAULT_UPDATE_THRESHOLD` to `vec_sim_common.h` to allow usage in RedisSearch. * fix test * apply review suggetion (cherry picked from commit 4f58e35) * remov is multi --------- Co-authored-by: meiravgri <[email protected]> Co-authored-by: meiravgri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOD-11784 Align first batch size updateTriggerThreshold for non-compressed svs tiered index
In tiered SVS indexes, vector transfer to the backend SVS index is triggered as follows:
trainingTriggerThreshold, defaults to ~10k vectors (10 * block_size = 1024)updateTriggerThreshold, defaults to 1024 vectors (block_size)For non-compressed SVS indexes, the large initial batch provides no performance or accuracy benefit, and creates an inconsistent user experience compared to subsequent batches.
MOD-11785 Expose
SVS_DEFAULT_UPDATE_THRESHOLDvia C APISVS_DEFAULT_UPDATE_THRESHOLD→SVS_VAMANA_DEFAULT_UPDATE_THRESHOLDSVS_VAMANA_DEFAULT_UPDATE_THRESHOLDtovec_sim_common.hto allow usage in RedisSearch.