Skip to content

[0.7] Avoid adding connection to marked deleted elements upon delete in-place in tiered index [MOD-7732]#544

Merged
alonre24 merged 2 commits into0.7from
backport-543-to-0.7
Sep 12, 2024
Merged

[0.7] Avoid adding connection to marked deleted elements upon delete in-place in tiered index [MOD-7732]#544
alonre24 merged 2 commits into0.7from
backport-543-to-0.7

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Sep 9, 2024

Description

Backport of #543 to 0.7.
Note that here the test should have slightly changed since we don't have the debug print neighbors function

…ce in tiered index [MOD-7732] (#543)

* test buggy scenario - WIP

* Fix logic for inplace, add test

* make test stricter + format

* avoid collecting marked deleted elements in the candidates selection phase.

* Meirav's CR

(cherry picked from commit 3325068)
@alonre24 alonre24 requested a review from GuyAv46 September 9, 2024 15:56
@alonre24 alonre24 enabled auto-merge September 9, 2024 15:57
@codecov
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (e370d3d) to head (6c5aea4).
Report is 1 commits behind head on 0.7.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.7     #544      +/-   ##
==========================================
- Coverage   95.82%   95.76%   -0.06%     
==========================================
  Files          69       69              
  Lines        4026     4042      +16     
==========================================
+ Hits         3858     3871      +13     
- Misses        168      171       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonre24 alonre24 added this pull request to the merge queue Sep 12, 2024
Merged via the queue into 0.7 with commit 8108a3d Sep 12, 2024
@alonre24 alonre24 deleted the backport-543-to-0.7 branch September 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant