Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
=======================================
Coverage 97.15% 97.16%
=======================================
Files 94 94
Lines 4846 4862 +16
=======================================
+ Hits 4708 4724 +16
Misses 138 138 ☔ View full report in Codecov by Sentry. |
GuyAv46
reviewed
Sep 8, 2024
GuyAv46
previously approved these changes
Sep 8, 2024
meiravgri
reviewed
Sep 9, 2024
Collaborator
meiravgri
left a comment
meiravgri
left a comment
There was a problem hiding this comment.
Good catch
few comments
meiravgri
approved these changes
Sep 9, 2024
|
Successfully created backport PR for |
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
…in-place in tiered index [MOD-7732] (#545) Avoid adding connection to marked deleted elements upon delete in-place in tiered index [MOD-7732] (#543) * test buggy scenario - WIP * Fix logic for inplace, add test * make test stricter + format * avoid collecting marked deleted elements in the candidates selection phase. * Meirav's CR (cherry picked from commit 3325068) Co-authored-by: alonre24 <[email protected]>
This was referenced Sep 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…in-place in tiered index [MOD-7732] (#544) * Avoid adding connection to marked deleted elements upon delete in-place in tiered index [MOD-7732] (#543) * test buggy scenario - WIP * Fix logic for inplace, add test * make test stricter + format * avoid collecting marked deleted elements in the candidates selection phase. * Meirav's CR (cherry picked from commit 3325068) * fix test for 0.7 so it won't use non exiting debug --------- Co-authored-by: alonre24 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Upon in-place deletion of vectors that occur after asynchronous deletion in the tiered index, we did not properly handle the repairs for the "marked deleted" vectors, as we allowed updating new connections to such elements. These elements will not be accounted for in the asynchronous repair for the marked deleted vector and may cause corruption in the graph state along the way.
This PR fixes this by checking the elements selected upon repairing a node due to in-place delete and NOT updating new connections to deleted vectors.
Mark if applicable