[8.2] Fix Profile Print on Missing Value - [MOD-10560]#9049
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3bbb26b. Configure here.
| actual_res = conn.execute_command('ft.profile', 'idx', 'search', 'query', '-ismissing(@t)', 'nocontent') | ||
| env.assertEqual(actual_res[0], [1, '1']) | ||
| env.assertEqual(actual_res[1][1][0][3], ['Type', 'NOT', 'Number of reading operations', 2, 'Child iterator', | ||
| ['Type', 'MISSING', 'Field', 't', 'Number of reading operations', 2, 'Estimated number of matches', 1]]) |
There was a problem hiding this comment.
Release notes checkbox not marked for user-facing fix
Low Severity
This PR fixes a user-facing bug where FT.PROFILE output was missing type information for ismissing() queries, but neither release notes checkbox in the PR description is checked. Per project rules, a concise release note is warranted. Suggested release note: "Fixed FT.PROFILE output for ismissing() queries to correctly display the MISSING iterator type and associated field name."
Additional Locations (1)
Triggered by project rule: Please assist in writing a GitHub release note for this PR, which is concise and focused on the user impact.
Reviewed by Cursor Bugbot for commit 3bbb26b. Configure here.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.2 #9049 +/- ##
==========================================
- Coverage 89.01% 88.93% -0.08%
==========================================
Files 260 260
Lines 42093 42093
Branches 3851 3851
==========================================
- Hits 37468 37435 -33
- Misses 4576 4609 +33
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Describe the changes in the pull request
8.2variant of #9051Mark if applicable
Release Notes
Note
Low Risk
Low risk: changes only
FT.PROFILEiterator printing for missing-field predicates and adds coverage; no query execution or index mutation logic is modified.Overview
Fixes
FT.PROFILEiterator output forismissing(@field)queries by detectingFIELD_EXPIRATION_MISSINGreaders and printing a dedicatedType: MISSINGentry including the missing field name.Adds a regression test covering both
ismissing(@t)and-ismissing(@t)to ensure the profile output includes the expectedMISSINGiterator (and nesting underNOT).Reviewed by Cursor Bugbot for commit 6f0f9d3. Bugbot is set up for automated code reviews on this repo. Configure here.