[8.4] Fix Profile Print on Missing Value - [MOD-10560]#9048
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b5dcb06. Configure here.
| printProfileType("MISSING"); | ||
| size_t fieldLen = 0; | ||
| const char *fieldName = HiddenString_GetUnsafe(it->sctx->spec->fields[it->filterCtx.field.value.index].fieldName, &fieldLen); | ||
| RedisModule_ReplyKV_StringBuffer(reply, "Field", fieldName, fieldLen); |
There was a problem hiding this comment.
Missing GitHub release note for this PR
Low Severity
The project rule requires assistance writing a GitHub release note. The PR checkbox indicates release notes are required. A suggested release note: "Fixed a crash or incorrect output when running FT.PROFILE on queries using ismissing() — the profile now correctly reports the iterator type as MISSING along with the associated field name."
Triggered by project rule: Please assist in writing a GitHub release note for this PR, which is concise and focused on the user impact.
Reviewed by Cursor Bugbot for commit b5dcb06. Configure here.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.4 #9048 +/- ##
==========================================
- Coverage 85.56% 85.53% -0.03%
==========================================
Files 337 337
Lines 53504 53506 +2
Branches 11023 11023
==========================================
- Hits 45779 45769 -10
- Misses 7582 7594 +12
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
2 participants
Describe the changes in the pull request
8.4variant of #9051Mark if applicable
Release Notes
Note
Low Risk
Low risk: changes are limited to
FT.PROFILEiterator output formatting and adds targeted tests; query execution behavior is unchanged.Overview
FT.PROFILEnow prints a distinct iterator type for missing-field queries (Type: MISSING) and includes the relevant field name, instead of misclassifying the iterator based on index reader flags.Adds regression tests covering
ismissing(@field)and its negation to validate the new profile output structure (includingNOTwrapping aMISSINGchild iterator).Reviewed by Cursor Bugbot for commit b5dcb06. Bugbot is set up for automated code reviews on this repo. Configure here.