Skip to content

[8.4] Fix HNSW vector index ghost memory leak (MOD-13761)#8849

Merged
meiravgri merged 2 commits into8.4from
meiravg_x_inc_edges-8.4
Mar 26, 2026
Merged

[8.4] Fix HNSW vector index ghost memory leak (MOD-13761)#8849
meiravgri merged 2 commits into8.4from
meiravg_x_inc_edges-8.4

Conversation

@meiravgri
Copy link
Copy Markdown
Collaborator

@meiravgri meiravgri commented Mar 26, 2026 •
edited by cursor Bot
Loading

backport #8843 to 8.4. bump vecsim to 8.4.0

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Release Notes

  • This PR requires release notes
  • This PR does not require release notes

Release Notes

  • This PR requires release notes
  • This PR does not require release notes

If a release note is required (bug fix / new feature / enhancement), describe the user impact of this PR in the title.

Note

Low Risk
The provided diff contains no code changes, so there is no functional or behavioral risk introduced by this PR.

Overview
No code changes are included in the provided diff, so this PR has no user-visible impact (it does not apply the intended fix for the HNSW vector index ghost memory leak).

Written by Cursor Bugbot for commit 0fda1fc. This will update automatically on new commits. Configure here.

@jit-ci
Copy link
Copy Markdown

jit-ci Bot commented Mar 26, 2026 •
edited
Loading

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR

Security scan by Jit

@meiravgri meiravgri requested a review from alonre24 March 26, 2026 05:20
@meiravgri meiravgri enabled auto-merge March 26, 2026 05:41
alonre24
alonre24 previously approved these changes Mar 26, 2026
View reviewed changes
@meiravgri meiravgri added this pull request to the merge queue Mar 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 26, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 26, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@meiravgri meiravgri enabled auto-merge March 26, 2026 12:23
@meiravgri meiravgri added this pull request to the merge queue Mar 26, 2026
@fcostaoliveira
Copy link
Copy Markdown
Contributor

fcostaoliveira commented Mar 26, 2026

Automated performance analysis summary

This comment was automatically generated given there is performance data available.

In summary:

  • Detected a total of 5 stable tests between versions.

You can check a comparison in detail via the grafana link

##

Details

Tests with No Significant Changes (5 tests)

Tests with No Significant Changes

Test Case Baseline 8.4 (median obs. +- std.dev) Comparison meiravg_x_inc_edges-8.4 (median obs. +- std.dev) % change (higher-better) Note
ftsb-10K-enwiki_abstract-hashes-term-suffix 2348 +- 1.5% (3 datapoints) 2374.0 1.1% No Change
search-ftsb-1700K-docs-union-iterators-q3 8.6 +- 1.1% (7 datapoints) 8.6 -1.0% No Change
search-high-cardinality-negation-term-comparison_union_all_other_terms 12 +- 4.5% (7 datapoints) 11.0 -3.6% potential REGRESSION
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-fulltext-filter 576 +- 5.3% (7 datapoints) 609.0 5.6% potential IMPROVEMENT
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-tag-filter 15632 +- 0.6% (7 datapoints) 15564.0 -0.4% No Change

@fcostaoliveira
Copy link
Copy Markdown
Contributor

fcostaoliveira commented Mar 26, 2026 •
edited
Loading

Automated performance analysis summary

This comment was automatically generated given there is performance data available.

In summary:

  • Detected a total of 27 stable tests between versions.
  • Detected a total of 10 highly unstable benchmarks (10 baseline).
  • Detected a total of 2 improvements above the improvement water line.
  • Detected a total of 2 regressions bellow the regression water line 8.0%.

You can check a comparison in detail via the grafana link

Performance Improvements - Comparison between 8.4 and meiravg_x_inc_edges-8.4.

Time Period from a month ago. (environment used: oss-standalone)

Test Case Baseline 8.4 (median obs. +- std.dev) Comparison meiravg_x_inc_edges-8.4 (median obs. +- std.dev) % change (higher-better) Note
search-numeric-sortby-desc-optimize 29 +- 7.6% (7 datapoints) 34 16.2% IMPROVEMENT
ftsb-10K-enwiki_pages-hashes-load 60554 +- 9.4% (3 datapoints) 66240 9.4% waterline=9.4%. IMPROVEMENT

Performance Regressions and Issues - Comparison between 8.4 and meiravg_x_inc_edges-8.4.

Time Period from a month ago. (environment used: oss-standalone)

Test Case Baseline 8.4 (median obs. +- std.dev) Comparison meiravg_x_inc_edges-8.4 (median obs. +- std.dev) % change (higher-better) Note
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-numeric-filter 159 +- 4.3% (7 datapoints) 124 -22.0% REGRESSION
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-union-query 2871 +- 12.7% UNSTABLE (7 datapoints) 2378 -17.2% UNSTABLE (baseline high variance); server: FT.SEARCH p50 increased 5.4% (baseline CV=4.5%); client: OverallQuantiles.allCommands.q50 increased 18.9% (baseline CV=13.5%); only client side confirms regression (server side stable) - insufficient evidence
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-intersection-query-non-sortable 45 +- 40.6% UNSTABLE (3 datapoints) 38 -14.4% UNSTABLE (baseline high variance); server: FT.SEARCH p50 increased 33.3% (baseline CV=17.4%); client: client latency stable; only server side confirms regression (client side stable) - insufficient evidence
search-numeric-sortby-optimize 29 +- 6.1% (7 datapoints) 25 -13.2% REGRESSION
search-ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query-non-sortable 166 +- 16.3% UNSTABLE (3 datapoints) 154 -7.7% UNSTABLE (baseline high variance); server: FT.SEARCH p50 increased 9.2% (baseline CV=16.9%); client: OverallQuantiles.allCommands.q50 increased 6.5% (baseline CV=10.5%); neither server nor client side confirms regression
ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query 820 +- 22.7% UNSTABLE (7 datapoints) 766 -6.5% UNSTABLE (baseline high variance); server: FT.SEARCH p50 increased 8.4% (baseline CV=14.1%); client: OverallQuantiles.allCommands.q50 increased 43.0% (baseline CV=31.0%); only client side confirms regression (server side stable) - insufficient evidence
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-union-query-non-sortable 1057 +- 15.2% UNSTABLE (7 datapoints) 1002 -5.2% UNSTABLE (baseline high variance); server: p50 latency stable; client: OverallQuantiles.allCommands.q50 increased 6.1% (baseline CV=12.4%); neither server nor client side confirms regression
ftsb-1M-enwiki_abstract-hashes-fulltext-2word-intersection-query 319 +- 12.9% UNSTABLE (3 datapoints) 316 -0.9% UNSTABLE (baseline high variance); server: p50 latency stable; client: OverallQuantiles.allCommands.q50 increased 12.8% (baseline CV=15.3%); only client side confirms regression (server side stable) - insufficient evidence
search-filtering-tag-numeric 304 +- 14.7% UNSTABLE (7 datapoints) 372 22.1% UNSTABLE (baseline high variance); server: FT.AGGREGATE p50 decreased 18.0% (baseline CV=17.4%); client: Latency decreased 21.1% (baseline CV=11.0%); neither server nor client side confirms regression
search-numeric-sortby-desc 2487 +- 25.5% UNSTABLE (7 datapoints) 3864 55.4% UNSTABLE (baseline high variance); server: FT.SEARCH p50 decreased 36.5% (baseline CV=19.7%); client: Latency decreased 35.6% (baseline CV=19.0%); neither server nor client side confirms regression
search-numeric 2431 +- 37.5% UNSTABLE (3 datapoints) 4084 68.0% UNSTABLE (baseline high variance); server: FT.SEARCH p50 decreased 41.5% (baseline CV=23.1%); client: Latency decreased 46.2% (baseline CV=22.4%); neither server nor client side confirms regression
search-numeric-sortby 2436 +- 32.8% UNSTABLE (3 datapoints) 4145 70.2% UNSTABLE (baseline high variance); server: FT.SEARCH p50 decreased 7.0% (baseline CV=26.3%); client: Latency decreased 6.4% (baseline CV=25.1%); neither server nor client side confirms regression
Tests with No Significant Changes (27 tests)

Tests with No Significant Changes

Test Case Baseline 8.4 (median obs. +- std.dev) Comparison meiravg_x_inc_edges-8.4 (median obs. +- std.dev) % change (higher-better) Note
ftsb-10K-enwiki_abstract-hashes-fulltext-sortby 88 +- 4.2% (7 datapoints) 90.00 1.9% No Change
ftsb-10K-enwiki_abstract-hashes-term-prefix 5938 +- 6.7% (7 datapoints) 6122.00 3.1% potential IMPROVEMENT
ftsb-10K-enwiki_abstract-hashes-term-suffix 2348 +- 1.5% (3 datapoints) 2374.00 1.1% No Change
ftsb-10K-enwiki_abstract-hashes-term-suffix-withsuffixtrie 16254 +- 1.0% (3 datapoints) 15892.00 -2.2% No Change
ftsb-10K-enwiki_abstract-hashes-term-wildcard 9116 +- 7.8% (7 datapoints) 8566.00 -6.0% potential REGRESSION
ftsb-10K-enwiki_pages-hashes-fulltext-mixed_simple-1word-query_write_1_to_read_20.yml 1098 +- 9.3% (7 datapoints) 1045.00 -4.8% waterline=9.3%. potential REGRESSION
ftsb-10K-multivalue-numeric-json 1058 +- 1.5% (7 datapoints) 1037.00 -2.0% No Change
ftsb-10K-singlevalue-numeric-json 510 +- 1.0% (7 datapoints) 503.00 -1.4% No Change
ftsb-1K-enwiki_abstract-hashes-term-contains 1997 +- 1.0% (7 datapoints) 2028.00 1.5% No Change
ftsb-1M-enwiki_abstract-hashes-load 24354 +- 5.8% (7 datapoints) 24991.00 2.6% No Change
ftsb-1M-nyc_taxis-ftadd-load 31597 +- 2.0% (7 datapoints) 29819.00 -5.6% potential REGRESSION
ftsb-1M-nyc_taxis-hashes-load 34609 +- 3.2% (3 datapoints) 33974.00 -1.8% No Change
search-aggregate-post-filter-simple.yml 17079 +- 1.1% (7 datapoints) 17172.00 0.5% No Change
search-filtering-tag-numeric-filter-pipeline 10869 +- 1.1% (7 datapoints) 11206.00 3.1% potential IMPROVEMENT
search-ftsb-10K-enwiki_abstract-hashes-term-withoutsuffix-trie 14129 +- 1.2% (3 datapoints) 14104.00 -0.2% No Change
search-ftsb-10K-enwiki_abstract-hashes-term-withsuffix-trie 13942 +- 2.3% (3 datapoints) 13961.00 0.1% No Change
search-ftsb-1700K-docs-union-iterators-q3 8.6 +- 1.1% (7 datapoints) 8.60 -1.0% No Change
search-ftsb-1M-enwiki_abstract-hashes-gc 497 +- 4.7% (7 datapoints) 476.00 -4.3% potential REGRESSION
search-ftsb-370K-docs-union-iterators-q4 8.7 +- 0.1% (3 datapoints) 8.60 -0.9% No Change
search-ftsb-5200K-docs-union-iterators-q1 0.88 +- 1.6% (7 datapoints) 0.87 -1.1% No Change
search-ftsb-5500K-docs-union-iterators-q2 1.2 +- 1.4% (7 datapoints) 1.20 0.0%
search-geo 220 +- 5.1% (7 datapoints) 219.00 -0.3% No Change
search-high-cardinality-negation-term-baseline 30 +- 6.4% (7 datapoints) 32.00 6.5% potential IMPROVEMENT
search-high-cardinality-negation-term-comparison_union_all_other_terms 12 +- 4.5% (7 datapoints) 11.00 -3.6% potential REGRESSION
search-numeric-optimize 7886 +- 0.3% (3 datapoints) 7886.00 0.0% No Change
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-fulltext-filter 576 +- 5.3% (7 datapoints) 609.00 5.6% potential IMPROVEMENT
vecsim-arxiv-titles-384-angular-filters-m16-ef-128-tag-filter 15632 +- 0.6% (7 datapoints) 15564.00 -0.4% No Change

Merged via the queue into 8.4 with commit baaa559 Mar 26, 2026
162 checks passed
@meiravgri meiravgri deleted the meiravg_x_inc_edges-8.4 branch March 26, 2026 14:59
@YaacovHazan YaacovHazan mentioned this pull request May 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alonre24 alonre24 alonre24 approved these changes

Assignees

No one assigned

Labels

action:run-benchmark size:XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meiravgri @fcostaoliveira @alonre24