Skip to content

[8.6] Fix config registration - [RED-171841]#8149

Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.6from
backport-8109-to-8.6
Jan 25, 2026
Merged

[8.6] Fix config registration - [RED-171841]#8149
redisearch-backport-pull-request[bot] merged 1 commit into8.6from
backport-8109-to-8.6

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Jan 24, 2026

Description

Backport of #8109 to 8.6.


Note

Updates module configuration setup and linkage.

  • Makes RediSearch_InitModuleConfig static and removes the registerConfiguration arg; adjust call sites accordingly
  • Always registers local config; registers cluster config when isClusterEnabled or clusterConfig.type == ClusterType_RedisLabs
  • Drops obsolete version-based logic and header prototype; confines function to module.c
  • Minor whitespace cleanup in SynDumpCommand

Written by Cursor Bugbot for commit f2e17d9. This will update automatically on new commits. Configure here.

* fix registration

* make static

(cherry picked from commit b634651)
@codecov
Copy link

codecov bot commented Jan 25, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.76%. Comparing base (999206c) to head (f2e17d9).
⚠️ Report is 4 commits behind head on 8.6.

Files with missing lines Patch % Lines
src/module.c 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.6    #8149      +/-   ##
==========================================
- Coverage   83.76%   83.76%   -0.01%     
==========================================
  Files         365      365              
  Lines       55277    55275       -2     
  Branches    14296    14296              
==========================================
- Hits        46304    46301       -3     
- Misses       8812     8813       +1     
  Partials      161      161              
Flag Coverage Δ
flow 84.57% <71.42%> (-0.10%) ⬇️
unit 50.68% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Jan 25, 2026
Merged via the queue into 8.6 with commit 191030b Jan 25, 2026
47 of 48 checks passed
@redisearch-backport-pull-request redisearch-backport-pull-request bot deleted the backport-8109-to-8.6 branch January 25, 2026 10:58
@oshadmi oshadmi self-requested a review January 25, 2026 11:45
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants