[8.6] MOD-13735 MOD-13181 Fix FT.PROFILE shard total profile time#8140
Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.6from Jan 25, 2026
Merged
Conversation
* Fix FT.PROFILE shard total profile time * Avoid double count on non-cursor Timeout Return failures * Move out of the if (Ok | Timeout) block * Add tests * Enhance tests to cover more cases (cherry picked from commit fd63e0c)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.6 #8140 +/- ##
==========================================
+ Coverage 83.75% 83.77% +0.01%
==========================================
Files 365 365
Lines 55277 55279 +2
Branches 14296 14296
==========================================
+ Hits 46297 46308 +11
+ Misses 8819 8810 -9
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ofiryanai
approved these changes
Jan 25, 2026
ofiryanai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #8129 to
8.6.Note
Fixes shard timing in
FT.PROFILEaggregate_exec.c, accumulate elapsed time for intermediate cursor reads intoreq->profileTotalTimewhen profiling cursor queries; keeps final read accounted inProfile_Print.durationfor global stats; no change to result serialization or control flow.Tests added
Total profile time≥ sum of Result ProcessorTimeacrossSEARCH/AGGREGATE, RESP2/RESP3, standalone/cluster, including multi-read cursors.Written by Cursor Bugbot for commit c57bdc9. This will update automatically on new commits. Configure here.