Skip to content

Fix config registration - [RED-171841]#8109

Merged
oshadmi merged 2 commits intomasterfrom
guyav-fix_missing_configs
Jan 24, 2026
Merged

Fix config registration - [RED-171841]#8109
oshadmi merged 2 commits intomasterfrom
guyav-fix_missing_configs

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Jan 20, 2026 •
edited by oshadmi
Loading

Register cluster configurations (used by the coordinator) not only when cluster-enable config is set,
But also when running Redis Enterprise, where this config is not necessarily set.
Also remove minimal Redis version check, since in RediSearch 8.x, Redis version is guaranteed to be 8.x.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Adjusts how module configuration is initialized and registered.

  • Makes RediSearch_InitModuleConfig static, removes the registerConfiguration arg, and always calls RegisterModuleConfig_Local
  • Registers cluster configuration when isClusterEnabled or clusterConfig.type == RedisLabs
  • Removes unused version gating logic and updates caller to new signature
  • Drops the now-unused declaration from module.h
  • Minor whitespace cleanup in FT.SYNDUMP path

Written by Cursor Bugbot for commit ea71fa7. This will update automatically on new commits. Configure here.

@GuyAv46 GuyAv46 requested a review from oshadmi January 20, 2026 18:46
@jit-ci
Copy link

jit-ci bot commented Jan 20, 2026

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@codecov
Copy link

codecov bot commented Jan 20, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.55%. Comparing base (5117945) to head (ea71fa7).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/module.c 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8109      +/-   ##
==========================================
- Coverage   83.57%   83.55%   -0.02%     
==========================================
  Files         364      364              
  Lines       55222    55220       -2     
  Branches    14199    14199              
==========================================
- Hits        46151    46139      -12     
- Misses       8915     8925      +10     
  Partials      156      156
Flag Coverage Δ
flow 84.35% <71.42%> (-0.03%) ⬇️
unit 50.49% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GuyAv46 GuyAv46 enabled auto-merge January 21, 2026 16:59
oshadmi
oshadmi reviewed Jan 22, 2026
View reviewed changes
oshadmi
oshadmi reviewed Jan 22, 2026
View reviewed changes
@GuyAv46 GuyAv46 changed the title Fix config registration Fix config registration - [RED-171841] Jan 22, 2026
@GuyAv46 GuyAv46 added this pull request to the merge queue Jan 22, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2026
@GuyAv46 GuyAv46 added this pull request to the merge queue Jan 22, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2026
@GuyAv46
Fix config registration - [RED-171841] (#8109)
acd0825 
* fix registration

* make static
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2026
@GuyAv46 GuyAv46 added this pull request to the merge queue Jan 22, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2026
@oshadmi oshadmi added this pull request to the merge queue Jan 24, 2026
Merged via the queue into master with commit b634651 Jan 24, 2026
44 of 45 checks passed
@oshadmi oshadmi deleted the guyav-fix_missing_configs branch January 24, 2026 23:49
@redisearch-backport-pull-request
Copy link
Contributor

redisearch-backport-pull-request bot commented Jan 24, 2026

Backport failed for 8.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 8.2
git worktree add -d .worktree/backport-8109-to-8.2 origin/8.2
cd .worktree/backport-8109-to-8.2
git switch --create backport-8109-to-8.2
git cherry-pick -x b634651a88a3ce3d109895733d678e12aaf1e9c1

@redisearch-backport-pull-request
Copy link
Contributor

redisearch-backport-pull-request bot commented Jan 24, 2026

Backport failed for 8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 8.4
git worktree add -d .worktree/backport-8109-to-8.4 origin/8.4
cd .worktree/backport-8109-to-8.4
git switch --create backport-8109-to-8.4
git cherry-pick -x b634651a88a3ce3d109895733d678e12aaf1e9c1

redisearch-backport-pull-request bot pushed a commit that referenced this pull request Jan 24, 2026
@GuyAv46 @github-actions
Fix config registration - [RED-171841] (#8109)
f2e17d9 
* fix registration

* make static

(cherry picked from commit b634651)
@redisearch-backport-pull-request redisearch-backport-pull-request bot mentioned this pull request Jan 24, 2026
Merged
@redisearch-backport-pull-request
Copy link
Contributor

redisearch-backport-pull-request bot commented Jan 24, 2026

Successfully created backport PR for 8.6:

GuyAv46 added a commit that referenced this pull request Jan 25, 2026
@GuyAv46
Fix config registration - [RED-171841] (#8109)
3218257 
* fix registration

* make static

(cherry picked from commit b634651)
GuyAv46 added a commit that referenced this pull request Jan 25, 2026
@GuyAv46
Fix config registration - [RED-171841] (#8109)
d52b1ab 
* fix registration

* make static

(cherry picked from commit b634651)
This was referenced Jan 25, 2026
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 25, 2026
@GuyAv46
[8.4] Fix config registration - [RED-171841] (#8152)
6d8a860 
Fix config registration - [RED-171841] (#8109)

* fix registration

* make static

(cherry picked from commit b634651)
github-merge-queue bot pushed a commit that referenced this pull request Jan 25, 2026
@GuyAv46
[8.2] Fix config registration - [RED-171841] (#8153)
b6a4ed7 
Fix config registration - [RED-171841] (#8109)

* fix registration

* make static

(cherry picked from commit b634651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oshadmi oshadmi oshadmi approved these changes

Assignees

No one assigned

Labels

backport 8.2 backport 8.4 backport 8.6 size:S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuyAv46 @oshadmi