Skip to content

[2.10] [MOD-13432] Fix FULLTEXT field metric count (#8037)#8084

Merged
lerman25 merged 1 commit into2.10from
backport-8037-to-2.10
Jan 19, 2026
Merged

[2.10] [MOD-13432] Fix FULLTEXT field metric count (#8037)#8084
lerman25 merged 1 commit into2.10from
backport-8037-to-2.10

Conversation

@lerman25
Copy link
Collaborator

@lerman25 lerman25 commented Jan 19, 2026

backport #8037 to 2.10


Note

Aligns field indexing metrics and their reporting.

  • Change FieldsGlobalStats_UpdateFieldDocsIndexed to accept FieldType and update all callers
  • For TEXT fields, increment metrics by newly added terms per indexing (writeCurEntries), not per document; remove old per-doc FULLTEXT increments
  • Keep non-TEXT metrics counting per field occurrence; update INFO output labels/comments accordingly
  • Add/adjust tests to validate new semantics: per-type counters (excluding TEXT-as-docs), TEXT term counting, multi-value JSON counted once per doc, and JSON NULL fields ignored

Written by Cursor Bugbot for commit 85f2454. This will update automatically on new commits. Configure here.

@lerman25 lerman25 force-pushed the backport-8037-to-2.10 branch from fc4cfa0 to 9f44568 Compare January 19, 2026 16:21
…com/RediSearch/RediSearch/issues/8037)](https://github.com/RediSearch/RediSearch/issues/8037))

* Fix metric full text metric counting

* initialize fieldspec

* Add missing include

* remove redundant lines

* test null fields

* Don't count null text fields

* reset counter

* typo fix

* remove redudant wrapper

* Count terms indexed

* remove extra line

* test text indexing

* fix test

(cherry picked from commit 4e09df1)
@lerman25 lerman25 force-pushed the backport-8037-to-2.10 branch from 9f44568 to 85f2454 Compare January 19, 2026 16:30
@lerman25 lerman25 enabled auto-merge January 19, 2026 16:45
@lerman25 lerman25 added this pull request to the merge queue Jan 19, 2026
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.43%. Comparing base (291ee49) to head (85f2454).
⚠️ Report is 1 commits behind head on 2.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             2.10    #8084      +/-   ##
==========================================
- Coverage   89.46%   89.43%   -0.03%     
==========================================
  Files         210      210              
  Lines       36268    36267       -1     
==========================================
- Hits        32448    32437      -11     
- Misses       3820     3830      +10     
Flag Coverage Δ
flow 84.11% <100.00%> (-0.16%) ⬇️
unit 42.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into 2.10 with commit 5f3141d Jan 19, 2026
15 checks passed
@lerman25 lerman25 deleted the backport-8037-to-2.10 branch January 19, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants