Fix edge case in clusterset - [MOD-13562]#8068
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8068 +/- ##
==========================================
- Coverage 84.01% 83.89% -0.13%
==========================================
Files 365 365
Lines 55097 55168 +71
Branches 14296 14296
==========================================
- Hits 46292 46283 -9
- Misses 8644 8724 +80
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
reviewed
Jan 18, 2026
alonre24
approved these changes
Jan 19, 2026
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
* collect all shards (including replicas and no slots) and filter only at the end * Add API description * Align usage * add a test * avoid string arg consuming of standalone flag params * fix unit tests * add another test * align and add flow tests * add another case (cherry picked from commit a2279bd)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
* collect all shards (including replicas and no slots) and filter only at the end * Add API description * Align usage * add a test * avoid string arg consuming of standalone flag params * fix unit tests * add another test * align and add flow tests * add another case (cherry picked from commit a2279bd)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
Fix edge case in clusterset - [MOD-13562] (#8068) * collect all shards (including replicas and no slots) and filter only at the end * Add API description * Align usage * add a test * avoid string arg consuming of standalone flag params * fix unit tests * add another test * align and add flow tests * add another case (cherry picked from commit a2279bd) Co-authored-by: GuyAv46 <[email protected]>
eyalrund
pushed a commit
that referenced
this pull request
Jan 22, 2026
* collect all shards (including replicas and no slots) and filter only at the end * Add API description * Align usage * add a test * avoid string arg consuming of standalone flag params * fix unit tests * add another test * align and add flow tests * add another case
LukeMathWalker
pushed a commit
that referenced
this pull request
Jan 26, 2026
* collect all shards (including replicas and no slots) and filter only at the end * Add API description * Align usage * add a test * avoid string arg consuming of standalone flag params * fix unit tests * add another test * align and add flow tests * add another case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fix an edge case in the Enterprise topology helper
CLUSTERSET.We now collect all the parsed shards into the temporary dictionary, and filter those we don't care for when building the final topology struct
Mark if applicable
Note
Improves Enterprise
CLUSTERSETtopology handling and robustness.MASTERshards that haveSLOTRANGE; introducesRLShard.isMasterMYIDto be absent from the final topology when the local node has no slots or is a replica; identifies this via storedMYIDoffsetUNIXADDRparsing to avoid consumingMASTER/SHARDtokens; enforces singleUNIXADDRand consistent per-shard valuesSetClusterCommand, whenmy_shard_idx == UINT32_MAX, updates cluster with an empty local slots array instead of failing or setting local idUNIXADDR, multipleUNIXADDR, and cases where the local shard is empty or a replicaRedisEnterprise_ParseTopologyreturn/my_shard_idxbehavior inredise.hWritten by Cursor Bugbot for commit 28f4386. This will update automatically on new commits. Configure here.