Conversation
(cherry picked from commit c11c1e5)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.0 #7984 +/- ##
==========================================
- Coverage 89.34% 89.20% -0.14%
==========================================
Files 200 200
Lines 37207 36282 -925
==========================================
- Hits 33243 32367 -876
+ Misses 3964 3915 -49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
pin alpine3 container to 3.22
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| echo "Core count: $(sysctl -n machdep.cpu.core_count 2>/dev/null || echo "N/A")" | ||
| echo "Thread count: $(sysctl -n machdep.cpu.thread_count 2>/dev/null || echo "N/A")" | ||
| echo "CPU vendor: $(sysctl -n machdep.cpu.vendor 2>/dev/null || echo "N/A")" | ||
| echo "CPU features: $(sysctl -n machdep.cpu.features 2>/dev/null || echo "N/A")" |
There was a problem hiding this comment.
CPU diagnostic uses Intel-only sysctl keys on ARM Macs
Low Severity
The new CPU information step uses machdep.cpu.* sysctl keys (brand_string, core_count, thread_count, vendor, features) which are Intel-specific and don't exist on Apple Silicon Macs. Since this PR specifically migrates to macos-latest which is now an ARM runner, all these sysctl commands will fail and output "N/A" on the ARM runners. The diagnostic step won't provide useful CPU information for the new ARM macOS environments. The workflow won't fail due to the || echo "N/A" fallback, but the diagnostic purpose is defeated. For ARM Macs, alternatives like sysctl hw.ncpu, sysctl hw.physicalcpu, or system_profiler SPHardwareDataType would be needed.
3 participants
Backport #6932 to 8.0
(cherry picked from commit c11c1e5)
Test: https://github.com/RediSearch/RediSearch/actions/runs/20772712199
To pass the merge queue test, this PR also includes:
Manual backport #7651 to 8.0
Test: https://github.com/RediSearch/RediSearch/actions/runs/20760950976
Note
Modernizes CI workflows and platform matrices.
macos-15-intel(x86_64) andmacos-latest(arm), replacing older runner labels inflow-macos.ymland macOS branches offlow-build-artifacts.ymlalpine:3toalpine:3.22across workflows, updating matrices, pre-step conditions, pre-deps, and node20 support/checkout cases intask-test.ymlandtask-build-artifacts.ymltask-get-linux-configurations.ymlto includealpine:3.22and adjust pre-dependency handlingtask-test.ymlfor better diagnosticsWritten by Cursor Bugbot for commit 35118ac. This will update automatically on new commits. Configure here.