Skip to content

fix crash in profile#7956

Closed
JoanFM wants to merge 3 commits intomasterfrom
joan-fix-crash-profile
Closed

fix crash in profile#7956
JoanFM wants to merge 3 commits intomasterfrom
joan-fix-crash-profile

Conversation

@JoanFM
Copy link
Collaborator

@JoanFM JoanFM commented Dec 31, 2025

Describe the changes in the pull request

A clear and concise description of what the PR is solving, including:

  1. Current: The current state briefly
  2. Change: What is the change
  3. Outcome: Adding the outcome

Which additional issues this PR fixes

  1. MOD-...
  2. #...

Main objects this PR modified

  1. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Strengthens safety in iterator profiling to avoid null dereferences.

  • In printInvIdxIt, add guards for root/root->current and term != NULL before accessing IndexResult_QueryTermRef and printing Term for TAG/TEXT cases
  • Leaves NUMERIC/GEO handling unchanged; only affects TAG/TEXT branches in inverted index profiling
  • Prevents crashes during profiling when no current result/term is available

Written by Cursor Bugbot for commit ee2679c. This will update automatically on new commits. Configure here.

@JoanFM JoanFM requested a review from meiravgri December 31, 2025 16:34
@JoanFM JoanFM self-assigned this Dec 31, 2025
@JoanFM JoanFM marked this pull request as ready for review December 31, 2025 16:34
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.96%. Comparing base (9fca0d6) to head (ee2679c).
⚠️ Report is 68 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7956      +/-   ##
==========================================
- Coverage   84.07%   83.96%   -0.11%     
==========================================
  Files         361      361              
  Lines       55098    55158      +60     
  Branches    14508    14508              
==========================================
- Hits        46324    46314      -10     
- Misses       8583     8653      +70     
  Partials      191      191              
Flag Coverage Δ
flow 84.88% <100.00%> (-0.15%) ⬇️
unit 51.02% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoanFM JoanFM closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant