Conversation
* mark legacy API as such * refactor spec's keysDict to hold char buffer * cleanups * make keysDict a dict for inverted indexes only (simplify value struct) * use bool * some comment fixes * address review comment * dead code cleanup (cherry picked from commit 692e14f)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7905 +/- ##
==========================================
- Coverage 86.10% 86.04% -0.07%
==========================================
Files 332 332
Lines 53587 53575 -12
Branches 11998 11998
==========================================
- Hits 46143 46098 -45
- Misses 7277 7310 +33
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #7843
Note
Modernizes how inverted-index terms are stored and accessed.
keysDictentries fromRedisModuleString/KeysDictValuetodict<CharBuf, InvertedIndex*>with custom hash/dup/compare/destructors; updatesmissingFieldDictval destructorCharBuftype andinvIdxDictType; switches term access/deletion to stackCharBuf(no Redis strings)Redis_OpenInvertedIndex(write flag nowbool) andRedis_OpenReaderAPIs to acceptRSTokenand createRSQueryTerminternally; updates all call sites inquery.cCharBufkeys fordictDelete, removes string frees, preserves stats updatesLegacy_fmtRedis{Term,SkipIndex,ScoreIndex}Key,Redis_LegacyDropScanHandler; updates usages inspec.cWritten by Cursor Bugbot for commit f75f3b9. This will update automatically on new commits. Configure here.