[8.4] MOD-13252 Support multiple warnings in reply #7900
Merged
Conversation
* take code from meiravg_persist_warnings_in_areq * take tests * fix test * review fixes * move test (cherry picked from commit 0b7aee5)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7900 +/- ##
==========================================
- Coverage 86.05% 86.01% -0.05%
==========================================
Files 332 332
Lines 53683 53690 +7
Branches 11998 11998
==========================================
- Hits 46198 46180 -18
- Misses 7318 7343 +25
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lerman25
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #7892 to 8.4
Note
Adds multi-warning support and consistent warning shapes across results and profiles.
warningarray via_replyWarnings(timeout, OOM, max prefix expansions, indexing OOM), and ensures it’s included alongsidetotal_resultsrpnet.c) now iterates the RESP3warningarray from shards, sets corresponding flags (timeout/max-prefix/OOM/indexing failure), and propagates timeouts even from empty replies'Warning': ['None']or multiple entries) rather than a single stringget_shards_profileWritten by Cursor Bugbot for commit 58c9e0d. This will update automatically on new commits. Configure here.