test: change timeout in test to not collide with RLTest timeout#7899
Merged
test: change timeout in test to not collide with RLTest timeout#7899
Conversation
nafraf
approved these changes
Dec 25, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7899 +/- ##
==========================================
- Coverage 84.22% 84.22% -0.01%
==========================================
Files 361 361
Lines 56301 56301
Branches 15720 15720
==========================================
- Hits 47420 47418 -2
- Misses 8665 8667 +2
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…because of ASM and add asm warnings in profile (#7869)(#7899)(#7913) (#8087) * manual backport of ASM warnings * remove some warning * test: change timeout test to not collide with RLTest timeout * asm warnings profile * add new case * test: add condition for source shard to pass migration * add back time sleep to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to get the info we want from the PIDs, we need the test to Timeout in the wait_for_migration_complete, but setting this timeout to 300 ( the same of the general RLTest timeout) seems to collide and does not the test kill the processes with SIGALRM and show the PID info.
Note
Test timeout adjustment
timeoutinwait_for_migration_complete(tests/pytests/test_asm.py) from300to200seconds to avoid colliding with RLTest's overall timeout and ensure SIGALRM handling for PID info collection.Written by Cursor Bugbot for commit 9bcb9f3. This will update automatically on new commits. Configure here.