[8.4] MOD-12807, MOD-12808: Register Cursor Sub-Commands as such#7888
Merged
Itzikvaknin merged 3 commits into8.4from Dec 25, 2025
Merged
[8.4] MOD-12807, MOD-12808: Register Cursor Sub-Commands as such#7888Itzikvaknin merged 3 commits into8.4from
Itzikvaknin merged 3 commits into8.4from
Conversation
* split cursor command * fix and improve tests * cover error cases * fix cursor leaks * Add "TODO: run hybrid cursor" back * remove new empty line * small test improvement * fix FT.CURSOR GC * de-flake test * make CURSOR PROFILE internal only
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7888 +/- ##
==========================================
- Coverage 86.00% 85.99% -0.01%
==========================================
Files 331 331
Lines 53065 53380 +315
Branches 11998 11998
==========================================
+ Hits 45637 45906 +269
- Misses 7261 7307 +46
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Itzikvaknin
force-pushed
the
manual-backport-6396-to-8.4
branch
from
9762018 to
7d55279
Compare
Itzikvaknin
changed the title
GuyAv46
previously approved these changes
Dec 25, 2025
GuyAv46
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #7571 to 8.4
Note
Register FT.CURSOR subcommands and refactor cursor handling
FT.CURSORinto true subcommands:READ,PROFILE,DEL,GC; register both external (FT.CURSOR) and internal (_FT.CURSOR) variants with cluster-safe dispatchRSCursorCommandwithRSCursorReadCommand,RSCursorProfileCommand,RSCursorDelCommand,RSCursorGCCommand; adjust distributed wrappers and commandstats namessendChunk_ReplyOnly_EmptyResultsand cursor read paths to takeRedisModuleCtx, internally create/end replies, and improve RESP2/RESP3 empty reply behavior and OOM warningsWritten by Cursor Bugbot for commit a6e9806. This will update automatically on new commits. Configure here.