[8.4] Remove non-TEXT fields from the spec's keys dictionary - [MOD-13150]#7887
Merged
[8.4] Remove non-TEXT fields from the spec's keys dictionary - [MOD-13150]#7887
Conversation
…7871) * move fields outside keysDict * remove dead defs * fix memory consumption test helper * test fixes * wip * reverting unnecessary changes * reverting unnecessary changes * fix memory calculations * fix memory calculations * small improvement * tidy ups * review fixes (cherry picked from commit 5668dd1)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7887 +/- ##
==========================================
- Coverage 86.05% 86.00% -0.05%
==========================================
Files 331 331
Lines 53368 53298 -70
Branches 11998 11998
==========================================
- Hits 45925 45839 -86
- Misses 7276 7292 +16
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #7871
Note
Shifts non-TEXT index structures from the global
spec->keysDictto per-field ownership, simplifying lifecycle and reducing keysDict scope to TEXT terms only.TagIndex_Open(fs),openNumericOrGeoIndex(spec, fs, ...),OpenGeometryIndex(fs, ...),openVectorIndex(fs, ...); removes key-formatted open pathsFieldSpecwithtagIndex,tree(numeric/geo),geometryIndex, andvecSimIndex; ensures proper freeing inFieldSpec_CleanupIndexSpec_LegacyGetFormattedKey,Redis_LegacyDeleteKey,HiddenString_LegacyDropFromKeySpace) used only for cleanup of legacy keysSPEC_INVIDXES_INFO) to reflect that non-TEXT entries are no longer stored inkeysDictWritten by Cursor Bugbot for commit 3add6f9. This will update automatically on new commits. Configure here.