[8.4] [MOD-12640] Handle warnings in empty FT.AGGREGATE replies (cluster) #7872
Merged
[8.4] [MOD-12640] Handle warnings in empty FT.AGGREGATE replies (cluster) #7872
Conversation
…7855) * introduce setWarnings use at the end of the reply or when empty reply is recieved * fixes * cleanups fix test * fix force timeout in debug * add tests: testEmptyReplyTimeoutWarningAggregate get stuck if we remove enforcing coord timeout testEmptyReplyTimeoutWarningProfileAggregate we dont get warning * more tests * move to file * fix type * remove comment * rename test file * add testEmptyReplyQueryOomWarning address todos * trmobr skip duplication * check waning exact (cherry picked from commit 701f719)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7872 +/- ##
==========================================
- Coverage 86.07% 86.02% -0.06%
==========================================
Files 331 331
Lines 53362 53368 +6
Branches 11998 11998
==========================================
- Hits 45933 45910 -23
- Misses 7262 7291 +29
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lerman25
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #7855 to 8.4
Note
Implements reliable coordinator handling of shard warnings when replies are empty in cluster FT.AGGREGATE.
processWarningsAndCleanupinrpnet.c; invoked on empty shard replies and at batch end to extractwarningfrom RESP3 meta, set coordinator warnings (timeout/OOM/max-prefix/indexing OOM), returnRS_RESULT_TIMEDOUTwhen appropriate, free reply, and reset stategetNextReply(empty rows) andrpnetNext(end-of-batch)aggregate_debug.c, only force coordinator timeout forTIMEOUT_AFTER_N 0 INTERNAL_ONLYunder RESP2; RESP3 propagates shard timeout warnings without forcingaggregate_debug.hdocs to clarify RESP3 vs RESP2 behaviortest_empty_reply_warnings.py; adjusttest_info_modules.pyandtest_query_oom.pyto expect propagated warnings and updated coordinator metrics (RESP3), and verify RESP2 fallback behaviorWritten by Cursor Bugbot for commit 5dc9064. This will update automatically on new commits. Configure here.