Remove non-TEXT fields from the spec's keys dictionary - [MOD-13150]#7871
Merged
Remove non-TEXT fields from the spec's keys dictionary - [MOD-13150]#7871
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7871 +/- ##
==========================================
+ Coverage 84.09% 84.23% +0.13%
==========================================
Files 360 360
Lines 56289 56225 -64
Branches 15717 15717
==========================================
+ Hits 47339 47362 +23
+ Misses 8734 8647 -87
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ofiryanai
previously approved these changes
Dec 24, 2025
Contributor
ofiryanai
left a comment
ofiryanai
left a comment
There was a problem hiding this comment.
few shallow comments, all in all good refactor
eyalrund
reviewed
Dec 24, 2025
eyalrund
reviewed
Dec 24, 2025
eyalrund
reviewed
Dec 24, 2025
oshadmi
reviewed
Dec 24, 2025
| } geometryOpts; | ||
| }; | ||
|
|
||
| // TODO: Move into union above when we stop supporting multi-type fields |
Collaborator
There was a problem hiding this comment.
@GuyAv46 You mean fields with option FieldSpec_Dynamic?
Collaborator
Author
There was a problem hiding this comment.
Yes. Referring here to the text-only data and the numeric pointer
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-7871-to-8.2 origin/8.2
cd .worktree/backport-7871-to-8.2
git switch --create backport-7871-to-8.2
git cherry-pick -x 5668dd1a51a6fd393c4f2721853ebd46528ff4e5 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.4
git worktree add -d .worktree/backport-7871-to-8.4 origin/8.4
cd .worktree/backport-7871-to-8.4
git switch --create backport-7871-to-8.4
git cherry-pick -x 5668dd1a51a6fd393c4f2721853ebd46528ff4e5 |
2 tasks
GuyAv46
added a commit
that referenced
this pull request
Dec 24, 2025
…7871) * move fields outside keysDict * remove dead defs * fix memory consumption test helper * test fixes * wip * reverting unnecessary changes * reverting unnecessary changes * fix memory calculations * fix memory calculations * small improvement * tidy ups * review fixes (cherry picked from commit 5668dd1)
GuyAv46
added a commit
that referenced
this pull request
Dec 24, 2025
…7871) * move fields outside keysDict * remove dead defs * fix memory consumption test helper * test fixes * wip * reverting unnecessary changes * reverting unnecessary changes * fix memory calculations * fix memory calculations * small improvement * tidy ups * review fixes (cherry picked from commit 5668dd1)
This was referenced Dec 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 28, 2025
…3150] (#7887) * Remove non-TEXT fields from the spec's keys dictionary - [MOD-13150] (#7871) * move fields outside keysDict * remove dead defs * fix memory consumption test helper * test fixes * wip * reverting unnecessary changes * reverting unnecessary changes * fix memory calculations * fix memory calculations * small improvement * tidy ups * review fixes (cherry picked from commit 5668dd1) * fixes for 8.4
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 29, 2025
…3150] (#7886) * Remove non-TEXT fields from the spec's keys dictionary - [MOD-13150] (#7871) * move fields outside keysDict * remove dead defs * fix memory consumption test helper * test fixes * wip * reverting unnecessary changes * reverting unnecessary changes * fix memory calculations * fix memory calculations * small improvement * tidy ups * review fixes (cherry picked from commit 5668dd1) * fixes for 8.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Today, when we want to get a non-text field index, we:
keysDictIn this PR, we move these objects from
keysDictand set them directly in the field spec. This eliminates the need for steps 2 and 3.In a following PR, we will simplify
keysDict, specifically the keys formatting, which, after this PR, is no longer required.Remove non-text fields from the spec's
keysDict, which should only be used for text inverted indexes.Deprecating
IndexSpec_GetFormattedKey- should only be used to upgrade legacy indexesMark if applicable
Note
Shifts ownership of non-TEXT indexes from the global
keysDictto per-field members onFieldSpec, simplifying lookups and lifecycle.fs->tree(numeric/geo),fs->tagOpts.tagIndex,fs->vectorOpts.vecSimIndex,fs->geometryOpts.geometryIndex; updatesFieldSpec_Cleanupto free themopenNumericOrGeoIndex(...),TagIndex_Open(FieldSpec*, ...),openVectorIndex(FieldSpec*, ...),OpenGeometryIndex(FieldSpec*, ...)IndexSpec_LegacyGetFormattedKey(...), renames helpers toHiddenString_LegacyDropFromKeySpaceandRedis_LegacyDeleteKey; use legacy paths only for dropping/upgrading old indexesNumericRangeTreetypedef) to new interfaces and lazy index creation behaviorWritten by Cursor Bugbot for commit 3d02cf2. This will update automatically on new commits. Configure here.