[2.10] MOD-13010: Fix cmp_strings() - correctly handle binary data with embedded NULLS#7771
Merged
[2.10] MOD-13010: Fix cmp_strings() - correctly handle binary data with embedded NULLS#7771
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7771 +/- ##
==========================================
- Coverage 89.41% 89.41% -0.01%
==========================================
Files 210 210
Lines 36138 36138
==========================================
- Hits 32314 32311 -3
- Misses 3824 3827 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kei-nan
approved these changes
Dec 15, 2025
oshadmi
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport #7765 to 2.10
Manual backport was needed due to different location of
value.cfile:src/value/value.csrc/value.cNote
Switch string comparison to memcmp to handle embedded NULLs and add a test verifying aggregate/groupby coherence with binary data.
cmp_stringsinsrc/value.cto usememcmp(instead ofstrncmp) for length-aware, binary-safe comparisons (handles embedded\0).test_mod_13010intests/pytests/test_issues.pyto validate consistent results betweenFT.AGGREGATEqueries (with/withoutGROUPBY/TOLIST) when field values contain embedded NULL bytes.Written by Cursor Bugbot for commit 3fc57cb. This will update automatically on new commits. Configure here.