MOD-12450: FT.HYBRID - Support vector blob only through parameter, drop support for inlined blob#7768
Merged
Itzikvaknin merged 9 commits intomasterfrom Dec 15, 2025
Conversation
- Enforce vector input is parameter & - Add subqueries count to FT.HYBRID Fix tests to support that
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
nafraf
reviewed
Dec 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7768 +/- ##
==========================================
- Coverage 84.77% 84.74% -0.04%
==========================================
Files 351 351
Lines 54761 54800 +39
Branches 14727 14764 +37
==========================================
+ Hits 46426 46442 +16
- Misses 8136 8159 +23
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nafraf
approved these changes
Dec 15, 2025
kei-nan
approved these changes
Dec 15, 2025
Itzikvaknin
deleted the
ivaknin-disable_direct_vector_blob_on_ft_hybrid
branch
Collaborator
Author
|
/backport |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.4
git worktree add -d .worktree/backport-7768-to-8.4 origin/8.4
cd .worktree/backport-7768-to-8.4
git switch --create backport-7768-to-8.4
git cherry-pick -x 9fb37a39e23d74ae83f97a5055f8e6e63349a7d1 |
Itzikvaknin
added a commit
that referenced
this pull request
Dec 17, 2025
…op support for inlined blob (#7768) * Intermediate work - Enforce vector input is parameter & - Add subqueries count to FT.HYBRID Fix tests to support that * All tests pass * Remove wrong comment * Fix testWarningsAndErrorsStandalone to use better use cases * Fix test_info_modules:testWarningsAndErrorsCluster.test_args_errors_cluster * Add (ParseHybridTest, testDirectVector) to verify correct error code&massage * CR comments * Fix hybrid query in test_info_modules:testWarningsAndErrorsCluster.test_syntax_errors_cluster * Fix testMissingSearchArgument
vishal-bala
added a commit
to redis/redis-vl-python
that referenced
this pull request
Dec 17, 2025
Support for inlined blobs was dropped in FT.HYBRID due to some sequences being misinterpreted (see RediSearch/RediSearch#7768). This PR updates the hybrid search implementation to pass vector data to hybrid searches via parameter substitution instead.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 17, 2025
…er, drop support for inlined blob (#7823) * MOD-12450: FT.HYBRID - Support vector blob only through parameter, drop support for inlined blob (#7768) * Intermediate work - Enforce vector input is parameter & - Add subqueries count to FT.HYBRID Fix tests to support that * All tests pass * Remove wrong comment * Fix testWarningsAndErrorsStandalone to use better use cases * Fix test_info_modules:testWarningsAndErrorsCluster.test_args_errors_cluster * Add (ParseHybridTest, testDirectVector) to verify correct error code&massage * CR comments * Fix hybrid query in test_info_modules:testWarningsAndErrorsCluster.test_syntax_errors_cluster * Fix testMissingSearchArgument * Continuation of the conflicts merge * Remove whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Support vector blob in
FT.HYBRID VSIM @vector_field vectoronly through parameter, drop support for inlined blobA clear and concise description of what the PR is solving, including:
Current:
Both
FT.HYBRID SEARCH * VSIM \x9a\x99andFT.HYBRID SEARCH * VSIM $BLOB PARAMS 2 BLOB \x9a\x99are valid.Change:
Only
FT.HYBRID SEARCH * VSIM $BLOB PARAMS 2 BLOB \x9a\x99is validOutcome: The bug where vectors beginning with a value similar to
$were misinterpreted has been resolved.Result:
The bug where vectors beginning with a value resembling $ were misinterpreted has been resolved.
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable
Note
Enforces parameter-only vector blobs in FT.HYBRID VSIM and updates all tests to use
$BLOBwithPARAMS, removing direct inline blob support.src/hybrid/parse_hybrid.c):$BLOB); inline blobs now return syntax error with a clear message.$BLOBandPARAMS.Written by Cursor Bugbot for commit 38b58a6. This will update automatically on new commits. Configure here.