[2.10] [MOD-12694] [MOD-12069] Add active_coord_threads metric#7723
Merged
[2.10] [MOD-12694] [MOD-12069] Add active_coord_threads metric#7723
Conversation
* Add multi-threading statistics tracking for active I/O threads * fix comment * add cpp test * fix spelling * address comment * remove unnecessary nre line * add "active_worker_threads" metric * fix comment imp tests * test cleanups * add test comne about the num queries and cleanups * fix declartion * remove coord threads * add active_coord_threads expose ConcurrentSearchPool_WorkingThreadCount * make the tests run... * add "active_worker_threads" metric * fix declartion * remove coord threads * make the tests run... * introduce workersThreadPool_isInitialized assert is initizlied in GlobalStats_GetMultiThreadingStats * cleanup * rename workersThreadPool_isCreated * introduce ConcurrentSearchPool_IsCreated * fix test * we dont need workers * remove ConcurrentSearchPool_IsCreated and workersThreadPool_isInitialized * fix merge (cherry picked from commit b0fc4ea)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
meiravgri
changed the title
JoanFM
approved these changes
Dec 10, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7723 +/- ##
==========================================
- Coverage 89.44% 89.42% -0.03%
==========================================
Files 210 210
Lines 36027 36034 +7
==========================================
- Hits 32226 32225 -1
- Misses 3801 3809 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #7546 to 2.10
Note
Adds
active_coord_threadsto multi-threading stats, sourced from the coordinator thread pool and exposed inINFO MODULES.active_coord_threadstoMultiThreadingStatsand populate it inGlobalStats_GetMultiThreadingStats()viaConcurrentSearchPool_WorkingThreadCount()(underRS_COORDINATOR).active_coord_threadsin themulti_threadingsection ofINFO MODULES.ConcurrentSearchPool_WorkingThreadCount()inconcurrent_ctx.cand declare it inconcurrent_ctx.h(with C++ guards).coord/src/rmr/test/test_io_runtime_ctx.c: initialize/destroyConcurrentSearchpool for metrics access.tests/pytests/test_info_modules.py: assertactive_coord_threadsis 0 when idle and, in clusterFT.AGGREGATE, equals the number of paused queries; minor wording updates.Written by Cursor Bugbot for commit 44097c7. This will update automatically on new commits. Configure here.