Skip to content

[2.8] backport #7556 pending workers + #7609 test fix to 2.8#7703

Merged
meiravgri merged 2 commits into2.8from
backport-7556-to-2.8
Dec 10, 2025
Merged

[2.8] backport #7556 pending workers + #7609 test fix to 2.8#7703
meiravgri merged 2 commits into2.8from
backport-7556-to-2.8

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Dec 9, 2025

#7556: MOD-12069 Add *_pending_jobs metrics
#7609: MOD-12831 test_info_modules:test_pending_jobs_metrics_search Extend output on timeout


Note

Add high/low priority pending jobs metrics to the workers threadpool and expose them via INFO MODULES, with supporting APIs and tests.

  • Backend / Threadpool:
    • Add redisearch_thpool_high_priority_pending_jobs and redisearch_thpool_low_priority_pending_jobs to fetch queue lengths.
    • Include pending jobs in redisearch_thpool_get_stats (lock-safe access).
  • Workers API:
    • Expose workersThreadPool_LowPriorityPendingJobsCount and workersThreadPool_HighPriorityPendingJobsCount.
  • Global Stats & INFO output:
    • Extend MultiThreadingStats with workers_low_priority_pending_jobs and workers_high_priority_pending_jobs.
    • Report new fields in INFO MODULES under multi_threading.
  • Tests:
    • Add tests validating initial and active worker thread metrics and new pending jobs metrics for FT.SEARCH/FT.AGGREGATE.
    • Introduce helpers: wait_for_condition, launch_cmds_in_bg_with_exception_check, and make load_vectors_to_redis field/dim aware (DEFAULT_VECTOR_FIELD_NAME).

Written by Cursor Bugbot for commit 9ce0204. This will update automatically on new commits. Configure here.

@meiravgri meiravgri changed the title backport #7556 + #7609 to 2.8 Add *_pending_jobs metrics + fix test Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.59%. Comparing base (a5b55a3) to head (9ce0204).
⚠️ Report is 1 commits behind head on 2.8.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.8    #7703      +/-   ##
==========================================
- Coverage   87.59%   87.59%   -0.01%     
==========================================
  Files         203      203              
  Lines       35130    35144      +14     
==========================================
+ Hits        30773    30785      +12     
- Misses       4357     4359       +2     
Flag Coverage Δ
flow 81.99% <100.00%> (-0.21%) ⬇️
unit 42.29% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri changed the title Add *_pending_jobs metrics + fix test [2.8] Add *_pending_jobs metrics + fix test Dec 9, 2025
@meiravgri meiravgri changed the title [2.8] Add *_pending_jobs metrics + fix test [2.8] backport #7556 pending workers + #7609 test fix to 2.8 Dec 10, 2025
@meiravgri meiravgri added this pull request to the merge queue Dec 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2025
@meiravgri meiravgri added this pull request to the merge queue Dec 10, 2025
Merged via the queue into 2.8 with commit 8d53193 Dec 10, 2025
13 checks passed
@meiravgri meiravgri deleted the backport-7556-to-2.8 branch December 10, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants