[2.8] Fix cursor logical leak - [MOD-12807]#7687
Merged
Conversation
* add a failing test * fix (cherry picked from commit 461908e)
GuyAv46
force-pushed
the
backport-7667-to-2.8
branch
from
82e7565 to
093cc70
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #7687 +/- ##
==========================================
- Coverage 87.59% 87.59% -0.01%
==========================================
Files 203 203
Lines 35119 35119
==========================================
- Hits 30764 30762 -2
- Misses 4355 4357 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #7667 to
2.8.Note
Ensure cursors are cleaned up and a clear error is returned when an index is dropped while a cursor is idle; also pause cursors when PROFILE is requested on a non-profile cursor.
src/aggregate/aggregate_exec.c):FT.CURSOR READ, if the cursor’s spec weak ref cannot be promoted (index dropped), immediatelyCursor_Free(cursor)and reply with error:"The index was dropped while the cursor was idle".FT.CURSOR PROFILE, when the cursor request is not profile, callCursor_Pause(cursor)before replying with an error.test_mod_12807validating error message and cursor cleanup after dropping the index during an active cursor session.Written by Cursor Bugbot for commit 093cc70. This will update automatically on new commits. Configure here.