[2.10] Fix cursor logical leak - [MOD-12807]#7686
Merged
Conversation
* add a failing test * fix (cherry picked from commit 461908e)
alonre24
approved these changes
Dec 9, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7686 +/- ##
==========================================
- Coverage 89.44% 89.42% -0.03%
==========================================
Files 210 210
Lines 36010 36012 +2
==========================================
- Hits 32210 32203 -7
- Misses 3800 3809 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #7667 to
2.10.Note
Free the cursor when its index was dropped before a cursor read and pause the cursor when PROFILE is requested for a non-profile cursor, with a regression test validating cursor cleanup and error behavior.
FT.CURSOR READ(cursorRead), replying with error"The index was dropped while the cursor was idle".FT.CURSOR PROFILE, if the cursor isn't a profile request, pause it again before returning an error.test_mod_12807to verify idle cursor is removed and proper error is returned after dropping the index, and to checkINFO MODULEScursor counters.Written by Cursor Bugbot for commit 2e16915. This will update automatically on new commits. Configure here.