Skip to content

[2.8] [MOD-12694] [MOD-12069] Add active_coord_threads metric#7665

Merged
meiravgri merged 6 commits into2.8from
backport-7546-to-2.8
Dec 10, 2025
Merged

[2.8] [MOD-12694] [MOD-12069] Add active_coord_threads metric#7665
meiravgri merged 6 commits into2.8from
backport-7546-to-2.8

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Dec 7, 2025

backport #7546 to 2.8


Note

Adds active_coord_threads metric to INFO MODULES by wiring coordinator thread-pool working count into global stats.

  • Stats/Info:
    • Add active_coord_threads to MultiThreadingStats and expose it in INFO MODULES (src/info/global_stats.{c,h}, src/info/info_redis.c).
    • Initialize and populate via a coordinator-provided callback CoordThreadCount_Func.
  • Coordinator:
    • Implement DistAggThreadPool_WorkingThreadCount() and register it to CoordThreadCount_Func on load (coord/src/module.c).
  • Concurrency:
    • Expose ConcurrentSearchPool_WorkingThreadCount(int poolId) to retrieve working thread count (src/concurrent_ctx.{c,h}).
  • Tests:
    • Add/adjust test to validate multi_threading section includes active_coord_threads initialized to 0 (tests/pytests/test_info_modules.py).

Written by Cursor Bugbot for commit 0a56dfe. This will update automatically on new commits. Configure here.

@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.59%. Comparing base (b24a354) to head (0a56dfe).
⚠️ Report is 3 commits behind head on 2.8.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.8    #7665      +/-   ##
==========================================
- Coverage   87.59%   87.59%   -0.01%     
==========================================
  Files         203      203              
  Lines       35119    35128       +9     
==========================================
+ Hits        30764    30771       +7     
- Misses       4355     4357       +2     
Flag Coverage Δ
flow 81.98% <100.00%> (-0.22%) ⬇️
unit 42.31% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* backport 7546

* move idfed cpp

(cherry picked from commit a8ecd32)
@meiravgri meiravgri requested a review from lerman25 December 9, 2025 05:49
@meiravgri meiravgri enabled auto-merge December 9, 2025 09:03
@meiravgri meiravgri added this pull request to the merge queue Dec 10, 2025
Merged via the queue into 2.8 with commit a5b55a3 Dec 10, 2025
13 checks passed
@meiravgri meiravgri deleted the backport-7546-to-2.8 branch December 10, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants