Skip to content

[8.4] [MOD-12392] Remove numDocs parameter from non-optimized Wildcard iterator#7615

Merged
LukeMathWalker merged 1 commit into8.4from
backport-7602-to-8.4
Dec 2, 2025
Merged

[8.4] [MOD-12392] Remove numDocs parameter from non-optimized Wildcard iterator#7615
LukeMathWalker merged 1 commit into8.4from
backport-7602-to-8.4

Conversation

@LukeMathWalker
Copy link
Collaborator

@LukeMathWalker LukeMathWalker commented Dec 2, 2025

…ator (#7602)

Remove numDocs parameter from non-optimized Wildcard iterator

(cherry picked from commit c9dd364)

Describe the changes in the pull request

A clear and concise description of what the PR is solving, including:

  1. Current: The current state briefly
  2. Change: What is the change
  3. Outcome: Adding the outcome

Which additional issues this PR fixes

  1. MOD-...
  2. #...

Main objects this PR modified

  1. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Note

Removes the numDocs parameter/state from the non-optimized Wildcard iterator, making NumEstimated return maxId, and updates all call sites, bindings, benchmarks, and tests accordingly.

  • Iterators (Wildcard)
    • Remove numDocs field from WildcardIterator and drop numDocs param from NewWildcardIterator_NonOptimized(maxId, weight).
    • Change WI_NumEstimated to return topId (maxId) instead of numDocs.
    • Update NewWildcardIterator(...) to call the new signature.
  • Headers/Bindings
    • Update src/iterators/wildcard_iterator.h declaration to new signature.
    • Adjust Rust FFI (rqe_iterators_bencher/src/ffi.rs) and C bench wrapper (benchers/c/wildcard.c) to new constructor.
  • Tests/Benchmarks
    • Update all tests and micro-benchmarks to use NewWildcardIterator_NonOptimized(maxId, weight).
    • Fix expectations where NumEstimated now equals maxId.
    • Touchpoints include test_cpp_iterator_{wildcard,union,intersection,not,optional}.cpp and benchmark_wildcard_non_optimized_iterator.cpp.

Written by Cursor Bugbot for commit 479f3c4. This will update automatically on new commits. Configure here.

…ator (#7602)

Remove numDocs parameter from non-optimized Wildcard iterator

(cherry picked from commit c9dd364)
@github-actions github-actions bot added the size:S label Dec 2, 2025
@GuyAv46 GuyAv46 changed the title [MOD-12392] Remove numDocs parameter from non-optimized Wildcard iter… [8.4] [MOD-12392] Remove numDocs parameter from non-optimized Wildcard iterator Dec 2, 2025
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.90%. Comparing base (4d9f181) to head (479f3c4).
⚠️ Report is 2 commits behind head on 8.4.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.4    #7615      +/-   ##
==========================================
- Coverage   85.91%   85.90%   -0.01%     
==========================================
  Files         331      331              
  Lines       52792    52791       -1     
  Branches    12004    12004              
==========================================
- Hits        45357    45351       -6     
- Misses       7268     7273       +5     
  Partials      167      167              
Flag Coverage Δ
flow 84.49% <100.00%> (-0.36%) ⬇️
unit 52.57% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LukeMathWalker LukeMathWalker added this pull request to the merge queue Dec 2, 2025
Merged via the queue into 8.4 with commit 1459015 Dec 2, 2025
26 checks passed
@LukeMathWalker LukeMathWalker deleted the backport-7602-to-8.4 branch December 2, 2025 17:33
@LukeMathWalker LukeMathWalker restored the backport-7602-to-8.4 branch February 6, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants