[8.4] [MOD-12392] Remove numDocs parameter from non-optimized Wildcard iterator#7615
Merged
LukeMathWalker merged 1 commit into8.4from Dec 2, 2025
Merged
[8.4] [MOD-12392] Remove numDocs parameter from non-optimized Wildcard iterator#7615LukeMathWalker merged 1 commit into8.4from
LukeMathWalker merged 1 commit into8.4from
Conversation
GuyAv46
approved these changes
Dec 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7615 +/- ##
==========================================
- Coverage 85.91% 85.90% -0.01%
==========================================
Files 331 331
Lines 52792 52791 -1
Branches 12004 12004
==========================================
- Hits 45357 45351 -6
- Misses 7268 7273 +5
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ator (#7602)
Remove numDocs parameter from non-optimized Wildcard iterator
(cherry picked from commit c9dd364)
Describe the changes in the pull request
A clear and concise description of what the PR is solving, including:
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable
Note
Removes the numDocs parameter/state from the non-optimized Wildcard iterator, making NumEstimated return maxId, and updates all call sites, bindings, benchmarks, and tests accordingly.
numDocsfield fromWildcardIteratorand dropnumDocsparam fromNewWildcardIterator_NonOptimized(maxId, weight).WI_NumEstimatedto returntopId(maxId) instead ofnumDocs.NewWildcardIterator(...)to call the new signature.src/iterators/wildcard_iterator.hdeclaration to new signature.rqe_iterators_bencher/src/ffi.rs) and C bench wrapper (benchers/c/wildcard.c) to new constructor.NewWildcardIterator_NonOptimized(maxId, weight).NumEstimatednow equalsmaxId.test_cpp_iterator_{wildcard,union,intersection,not,optional}.cppandbenchmark_wildcard_non_optimized_iterator.cpp.Written by Cursor Bugbot for commit 479f3c4. This will update automatically on new commits. Configure here.