[8.4] Register Cursor Sub-Commands as such - [MOD-12807, MOD-12808]#7611
Closed
redisearch-backport-pull-request[bot] wants to merge 1 commit into8.4from
Closed
[8.4] Register Cursor Sub-Commands as such - [MOD-12807, MOD-12808]#7611redisearch-backport-pull-request[bot] wants to merge 1 commit into8.4from
redisearch-backport-pull-request[bot] wants to merge 1 commit into8.4from
Conversation
* split cursor command * fix and improve tests * cover error cases * fix cursor leaks * Add "TODO: run hybrid cursor" back * remove new empty line * small test improvement * fix FT.CURSOR GC * de-flake test * make CURSOR PROFILE internal only (cherry picked from commit 6945fd6)
2 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| static int CursorCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc) { | ||
| static inline int CursorCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int argc, RedisModuleCmdFunc subcmd, ConcurrentCmdHandler dist_callback) { |
There was a problem hiding this comment.
Bug: GC subcommand incorrectly requires 4 arguments in cluster mode
The CursorCommand wrapper, used for distributed cursor subcommands, incorrectly checks argc < 4. This prevents FT.CURSOR GC {index} from working in cluster mode, as it only requires 3 arguments. The internal RSCursorGCCommand correctly handles 3 arguments, but the wrapper rejects valid calls.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7611 +/- ##
==========================================
+ Coverage 85.91% 85.93% +0.01%
==========================================
Files 331 331
Lines 52792 52805 +13
Branches 12004 12004
==========================================
+ Hits 45357 45377 +20
+ Misses 7268 7261 -7
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
auto-merge was automatically disabled
December 7, 2025 13:06
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7571 to
8.4.Note
Registers FT.CURSOR subcommands (READ/PROFILE/DEL/GC), refactors cursor reply handling and coordinator routing, and updates tests and metrics accordingly.
FT.CURSORsubcommands:READ,PROFILE,DEL,GC(external and internal_FT.CURSOR).RSCursorCommandwith dedicated handlers:RSCursorReadCommand,RSCursorProfileCommand,RSCursorDelCommand,RSCursorGCCommand.CursorCommandwrapper and per-subcommand internals).sendChunk_ReplyOnly_EmptyResultsto acceptRedisModuleCtx *and self-createRedisModule_Reply.RedisModuleCtxand manage reply lifecycle (cursorRead, bg variant, error on dropped index).FT.CURSOR GCnow aggregates local/coord results and returns-1only when both quick-checks return-1.cmdstat__FT.CURSOR|READ).RediSearch_InitModuleInternal,RedisModule_OnLoad).PROFILE, GC edge-cases, dropped-index during cursor read/profile, and updated commandstats keys.Written by Cursor Bugbot for commit 8931a09. This will update automatically on new commits. Configure here.