MOD-12823 Fix ActiveIoThreadsMetric test timeout #7605
Merged
Conversation
meiravgri
changed the title
meiravgri
changed the title
ActiveIoThreadsMetric test timeout
JoanFM
previously approved these changes
Dec 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7605 +/- ##
==========================================
- Coverage 84.75% 84.71% -0.05%
==========================================
Files 351 351
Lines 54204 54204
Branches 14567 14567
==========================================
- Hits 45941 45919 -22
- Misses 8072 8094 +22
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
JoanFM
approved these changes
Dec 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.2
git worktree add -d .worktree/backport-7605-to-8.2 origin/8.2
cd .worktree/backport-7605-to-8.2
git switch --create backport-7605-to-8.2
git cherry-pick -x 81173b7238be09ad875367708d2b1166a6d7fe4c |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.4
git worktree add -d .worktree/backport-7605-to-8.4 origin/8.4
cd .worktree/backport-7605-to-8.4
git switch --create backport-7605-to-8.4
git cherry-pick -x 81173b7238be09ad875367708d2b1166a6d7fe4c |
meiravgri
added a commit
that referenced
this pull request
Dec 3, 2025
meiravgri
added a commit
that referenced
this pull request
Dec 3, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 3, 2025
* backport 7546 + #7605 fix uv thread test MOD-12823 * move idfed cpp
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
* WIP: implment for coordinator level backport 7546 + #7605 fix uv thread test MOD-12823 * remove test WITHCURSOR * revers * remove empty line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test had a race between the test thread setting
loop_th_ready = trueand the UV loop thread reading it inrqAsyncCb().If the UV thread won the race and saw
loop_th_ready == false, it would skip callback execution and never retry, causing the test to timeout waiting for the callback to start.Fixed by setting
loop_th_ready = truebefore scheduling the uv callback.Note
Stabilizes ActiveIoThreadsMetric by marking the loop ready before scheduling, using a timed wait for start/completion, and unskipping the test.
tests/cpptests/coord_tests/test_cpp_io_runtime_ctx.cpp:ctx->uv_runtime.loop_th_ready = truebefore scheduling the slow callback.rqAsyncCb.RS::WaitForConditionto detect callback start and completion (reusesuccess).GTEST_SKIPto re-enable theActiveIoThreadsMetrictest.Written by Cursor Bugbot for commit 27f2a67. This will update automatically on new commits. Configure here.