[2.8] [MOD-12069] [MOD-12695] Add active_io_threads metric#7597
[2.8] [MOD-12069] [MOD-12695] Add active_io_threads metric#7597
Conversation
meiravgri
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.8 #7597 +/- ##
==========================================
- Coverage 87.54% 87.54% -0.01%
==========================================
Files 203 203
Lines 34924 34939 +15
==========================================
+ Hits 30574 30587 +13
- Misses 4350 4352 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /* start the event loop side thread */ | ||
| static void sideThread(void *arg) { | ||
| atomic_store(&loop_started, true); // Signal that loop thread is starting | ||
| while (1) { |
There was a problem hiding this comment.
why do u have this loop? uv_run should be enough it actually runs the event loop
There was a problem hiding this comment.
i copied from the production code 🤷
tests/pytests/test_info_modules.py
Outdated
|
|
||
| SEARCH_PREFIX = 'search_' | ||
|
|
||
| # @skip(cluster=False) |
There was a problem hiding this comment.
it was removed in the following pr so i kept it here to avoid conflicts but ill have conflicts anyway :D
JoanFM
left a comment
JoanFM
left a comment
There was a problem hiding this comment.
small comment, may be relevant for 2.10
2 participants
Description
Backport of #7552 (originated from #7530) to
2.8.Note
Adds an
active_io_threadsmetric, exposes it under a newmulti_threadingINFO section, and updates the RQ work queue to maintain it with tests.MultiThreadingStatswithactive_io_threadstoglobal_stats.GlobalStats_UpdateActiveIoThreads(int)andGlobalStats_GetMultiThreadingStats().coord/src/rmr/rq.c):rqAsyncCbtoGlobalStats_UpdateActiveIoThreads(±1)around callback execution.multi_threadingsection withactive_io_threadsinsrc/info/info_redis.c.coord/src/rmr/test/test_io_runtime_ctx.cvalidating metric increases during a slow callback and returns to 0.tests/pytests/test_info_modules.pycheckingmulti_threadingsection exists andactive_io_threadsstarts at0.Written by Cursor Bugbot for commit e8b3b6d. This will update automatically on new commits. Configure here.