Skip to content

[8.4] [MOD-12789] test: fix flaky thpool test#7584

Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.4from
backport-7581-to-8.4
Dec 1, 2025
Merged

[8.4] [MOD-12789] test: fix flaky thpool test#7584
redisearch-backport-pull-request[bot] merged 1 commit into8.4from
backport-7581-to-8.4

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Dec 1, 2025

Description

Backport of #7581 to 8.4.


Note

Relaxes thread count assertions and adds a wait loop in TestAddThreadsToEmptyPool to handle transient overshoot when re-adding threads after reducing to zero.

  • Tests
    • tests/cpptests/test_cpp_thpool.cpp
      • In PriorityThpoolTestRuntimeConfig.TestAddThreadsToEmptyPool:
        • Relax thread count check from ASSERT_EQ(...num_threads_alive, RUNTIME_CONFIG_N_THREADS) to ASSERT_GE(...) after re-adding threads.
        • Add loop to wait until num_threads_alive settles to RUNTIME_CONFIG_N_THREADS after pending removals.
        • Keep initialization assertions unchanged.

Written by Cursor Bugbot for commit 805de3a. This will update automatically on new commits. Configure here.

test: fix flaky thpool test
(cherry picked from commit b35b3ee)
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.87%. Comparing base (ac92116) to head (805de3a).
⚠️ Report is 1 commits behind head on 8.4.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.4    #7584      +/-   ##
==========================================
- Coverage   85.95%   85.87%   -0.09%     
==========================================
  Files         331      331              
  Lines       52667    52667              
  Branches    12004    12004              
==========================================
- Hits        45272    45227      -45     
- Misses       7228     7273      +45     
  Partials      167      167              
Flag Coverage Δ
flow 84.43% <ø> (-0.23%) ⬇️
unit 52.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Dec 1, 2025
Merged via the queue into 8.4 with commit 9e59c5e Dec 1, 2025
28 checks passed
@redisearch-backport-pull-request redisearch-backport-pull-request bot deleted the backport-7581-to-8.4 branch December 1, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant