[8.4] [MOD-12789] test: fix flaky thpool test#7584
Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.4from Dec 1, 2025
Merged
[8.4] [MOD-12789] test: fix flaky thpool test#7584redisearch-backport-pull-request[bot] merged 1 commit into8.4from
redisearch-backport-pull-request[bot] merged 1 commit into8.4from
Conversation
test: fix flaky thpool test (cherry picked from commit b35b3ee)
2 tasks
JoanFM
approved these changes
Dec 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.4 #7584 +/- ##
==========================================
- Coverage 85.95% 85.87% -0.09%
==========================================
Files 331 331
Lines 52667 52667
Branches 12004 12004
==========================================
- Hits 45272 45227 -45
- Misses 7228 7273 +45
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7581 to
8.4.Note
Relaxes thread count assertions and adds a wait loop in
TestAddThreadsToEmptyPoolto handle transient overshoot when re-adding threads after reducing to zero.tests/cpptests/test_cpp_thpool.cppPriorityThpoolTestRuntimeConfig.TestAddThreadsToEmptyPool:ASSERT_EQ(...num_threads_alive, RUNTIME_CONFIG_N_THREADS)toASSERT_GE(...)after re-adding threads.num_threads_alivesettles toRUNTIME_CONFIG_N_THREADSafter pending removals.Written by Cursor Bugbot for commit 805de3a. This will update automatically on new commits. Configure here.