[8.2] [MOD-12789] test: fix flaky thpool test#7583
Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.2from Dec 1, 2025
Merged
[8.2] [MOD-12789] test: fix flaky thpool test#7583redisearch-backport-pull-request[bot] merged 1 commit into8.2from
redisearch-backport-pull-request[bot] merged 1 commit into8.2from
Conversation
test: fix flaky thpool test (cherry picked from commit b35b3ee)
2 tasks
JoanFM
approved these changes
Dec 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.2 #7583 +/- ##
==========================================
- Coverage 89.51% 89.47% -0.05%
==========================================
Files 253 253
Lines 41037 41037
Branches 3725 3725
==========================================
- Hits 36735 36716 -19
- Misses 4253 4272 +19
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7581 to
8.2.Note
Stabilizes thpool runtime-config test by asserting num_threads_alive >= after add, then waiting until it equals RUNTIME_CONFIG_N_THREADS.
tests/cpptests/test_cpp_thpool.cpp:TestAddThreadsToEmptyPool, relax thread count check toASSERT_GE(stats.num_threads_alive, RUNTIME_CONFIG_N_THREADS)after adding threads.num_threads_alivedrops toRUNTIME_CONFIG_N_THREADS, then assert equality.Written by Cursor Bugbot for commit b1589ad. This will update automatically on new commits. Configure here.