Skip to content

[8.2] [MOD-12789] test: fix flaky thpool test#7583

Merged
redisearch-backport-pull-request[bot] merged 1 commit into8.2from
backport-7581-to-8.2
Dec 1, 2025
Merged

[8.2] [MOD-12789] test: fix flaky thpool test#7583
redisearch-backport-pull-request[bot] merged 1 commit into8.2from
backport-7581-to-8.2

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Dec 1, 2025

Description

Backport of #7581 to 8.2.


Note

Stabilizes thpool runtime-config test by asserting num_threads_alive >= after add, then waiting until it equals RUNTIME_CONFIG_N_THREADS.

  • Tests:
    • tests/cpptests/test_cpp_thpool.cpp:
      • In TestAddThreadsToEmptyPool, relax thread count check to ASSERT_GE(stats.num_threads_alive, RUNTIME_CONFIG_N_THREADS) after adding threads.
      • Add wait loop until num_threads_alive drops to RUNTIME_CONFIG_N_THREADS, then assert equality.
      • Keeps pool initialized checks; ensures eventual consistency of thread removal.

Written by Cursor Bugbot for commit b1589ad. This will update automatically on new commits. Configure here.

test: fix flaky thpool test
(cherry picked from commit b35b3ee)
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.47%. Comparing base (0a1804e) to head (b1589ad).
⚠️ Report is 1 commits behind head on 8.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.2    #7583      +/-   ##
==========================================
- Coverage   89.51%   89.47%   -0.05%     
==========================================
  Files         253      253              
  Lines       41037    41037              
  Branches     3725     3725              
==========================================
- Hits        36735    36716      -19     
- Misses       4253     4272      +19     
  Partials       49       49              
Flag Coverage Δ
flow 82.44% <ø> (+0.16%) ⬆️
unit 47.64% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Dec 1, 2025
Merged via the queue into 8.2 with commit 3fc8edf Dec 1, 2025
25 checks passed
@redisearch-backport-pull-request redisearch-backport-pull-request bot deleted the backport-7581-to-8.2 branch December 1, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant