[2.10] [MOD-12789] test: fix flaky thpool test#7582
Merged
Conversation
test: fix flaky thpool test (cherry picked from commit b35b3ee)
2 tasks
JoanFM
approved these changes
Dec 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7582 +/- ##
==========================================
- Coverage 89.31% 89.29% -0.03%
==========================================
Files 207 207
Lines 35504 35504
==========================================
- Hits 31711 31702 -9
- Misses 3793 3802 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoanFM
approved these changes
Dec 1, 2025
meiravgri
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7581 to
2.10.Note
In
tests/cpptests/test_cpp_thpool.cpp, relax thread-count assertion to >= and add a wait loop untilnum_threads_aliveequals the configured value to avoid flakiness after re-adding threads.Written by Cursor Bugbot for commit f366567. This will update automatically on new commits. Configure here.