Skip to content

[8.4] Rust CI improvements#7559

Merged
redisearch-backport-pull-request[bot] merged 2 commits into8.4from
backport-7520-to-8.4
Dec 1, 2025
Merged

[8.4] Rust CI improvements#7559
redisearch-backport-pull-request[bot] merged 2 commits into8.4from
backport-7520-to-8.4

Conversation

@redisearch-backport-pull-request
Copy link
Contributor

@redisearch-backport-pull-request redisearch-backport-pull-request bot commented Nov 27, 2025

Description

Backport of #7520 to 8.4.


Note

Centralizes the pinned Rust nightly via .rust-nightly, adds a root rust-toolchain.toml, enables Rust caching in CI, and updates scripts and .dockerignore accordingly.

  • CI:
    • Add Rust caching step using Swatinem/rust-cache@v2 in /.github/workflows/task-test.yml with workspace src/redisearch_rs -> ../../bin/redisearch_rs.
  • Toolchain/Version pinning:
    • Introduce .rust-nightly (pinned nightly-2025-07-30) and consume it in build.sh, .install/test_deps/install_rust_deps.sh, and tests/deps/setup_rejson.sh.
    • Add root rust-toolchain.toml (channel = "1.91.1") and remove src/redisearch_rs/rust-toolchain.toml.
  • Infrastructure:
    • Update .dockerignore to include .rust-nightly and rust-toolchain.toml in build context.

Written by Cursor Bugbot for commit a1f42fa. This will update automatically on new commits. Configure here.

* Move nightly version to a standalone .rust-nightly file.

All nightly-related references to build.sh have been updated
to use .rust-nightly as the source of truth.

* Copy `.rust-nightly` rather than `build.sh` into the CI container.

It gets rid of unnecessary rebuilds, since the nightly version was
the only thing we cared about from `build.sh` when building the container.

* Use a specific stable version of Rust.

Using a specific version, the CI container is correctly rebuilt whenever that version changes.
It also moves the Rust toolchain file to the root of the repository, to ease
copying it into the container during build.

* Cache Rust packages in CI.

* Only use the cache action if Node is supported.

* Trigger build with cache hit

(cherry picked from commit 7bc0ece)
@redisearch-backport-pull-request redisearch-backport-pull-request bot added enforce:coverage Run coverage flow even on draft pull request enforce:sanitize Run sanitizer flow even on draft pull request enforce:test Run the test suite even if no code has changed. size:S labels Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.86%. Comparing base (d8d8dfd) to head (a1f42fa).
⚠️ Report is 11 commits behind head on 8.4.

Additional details and impacted files
@@            Coverage Diff             @@
##              8.4    #7559      +/-   ##
==========================================
- Coverage   85.92%   85.86%   -0.06%     
==========================================
  Files         330      331       +1     
  Lines       52536    52667     +131     
  Branches    12001    12004       +3     
==========================================
+ Hits        45139    45224      +85     
- Misses       7230     7276      +46     
  Partials      167      167              
Flag Coverage Δ
flow 84.46% <ø> (-0.15%) ⬇️
unit 52.38% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@redisearch-backport-pull-request redisearch-backport-pull-request bot added this pull request to the merge queue Dec 1, 2025
Merged via the queue into 8.4 with commit 4628cef Dec 1, 2025
25 checks passed
@redisearch-backport-pull-request redisearch-backport-pull-request bot deleted the backport-7520-to-8.4 branch December 1, 2025 15:53
@LukeMathWalker LukeMathWalker restored the backport-7520-to-8.4 branch February 6, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enforce:coverage Run coverage flow even on draft pull request enforce:sanitize Run sanitizer flow even on draft pull request enforce:test Run the test suite even if no code has changed. size:S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants