[2.10] [MOD-12069] [MOD-12695] Add active_io_threads metric #7558
Merged
[2.10] [MOD-12069] [MOD-12695] Add active_io_threads metric #7558
active_io_threads metric #7558Conversation
* take things that has no diffrence * remove unrelated changes in test_info_modules * add io threads update to rqAsyncCb * fix test (cherry picked from commit d75adea)
meiravgri
previously approved these changes
Nov 27, 2025
meiravgri
changed the title
active_io_threads metric active_io_threads metric
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.10 #7558 +/- ##
==========================================
- Coverage 89.31% 89.29% -0.02%
==========================================
Files 207 207
Lines 35504 35522 +18
==========================================
+ Hits 31711 31720 +9
- Misses 3793 3802 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoanFM
previously approved these changes
Dec 1, 2025
JoanFM
reviewed
Dec 2, 2025
|
|
||
| SEARCH_PREFIX = 'search_' | ||
|
|
||
| # @skip(cluster=False) |
JoanFM
approved these changes
Dec 2, 2025
Contributor
Author
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-7558-to-2.8 origin/2.8
cd .worktree/backport-7558-to-2.8
git switch --create backport-7558-to-2.8
git cherry-pick -x 6ae791d924c5317f0c890bcaa075b2d9baa547d8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7552 (originated from #7530) to
2.10.Note
Adds
active_io_threadsmetric tracked around IO callbacks and exposes it under INFO MODULES, with supporting tests and minimal APIs.MultiThreadingStatsand new APIsGlobalStats_UpdateActiveIoThreads/GlobalStats_GetMultiThreadingStatsinsrc/info/global_stats.{h,c}.coord/src/rmr/rq.cby incrementing/decrementingactive_io_threadsaroundreq->cb(...).RQ_Debug_SetLoopReady()incoord/src/rmr/rq.{h,c}to mark loop ready (for tests) and trigger pending queues.multi_threadingsection withactive_io_threadsinsrc/info/info_redis.c.coord/src/rmr/test/test_io_runtime_ctx.cverifying metric increments during a long-running callback and returns to 0.tests/pytests/test_info_modules.py::test_active_io_threads_statsvalidating INFO output and initial value.WaitForConditionintests/cpptests/common.h.Written by Cursor Bugbot for commit 51db8ca. This will update automatically on new commits. Configure here.