[MOD-12694] [MOD-12069] Add active_coord_threads metric by meiravgri · Pull Request #7546 · RediSearch/RediSearch

meiravgri · 2025-11-27T04:49:47Z

Extends the multi_threading section in INFO MODULES by adding search_active_coord_threads metric to track currently executing coordinator thread queries.

Continues #7530 which added search_multi_threading section and search_active_io_threads field.

INFO MODULES Output

# search_multi_threading
...
search_active_coord_threads:0

Note

Adds coordinator thread activity metric to INFO MODULES, backed by ConcurrentSearch pool, and updates tests accordingly.

Metrics/INFO
- Add active_coord_threads to multi_threading in INFO MODULES via GlobalStats_GetMultiThreadingStats() using ConcurrentSearchPool_WorkingThreadCount().
Concurrency
- Introduce ConcurrentSearchPool_WorkingThreadCount() in src/concurrent_ctx.{h,c}; add extern "C" guards for C++.
- Remove unused workersThreadPool_isCreated() and its assertion usage.
Tests
- C++: initialize/destroy coordinator pool in ActiveIoThreadsMetric test.
- Python: validate search_active_coord_threads exists and reflects paused FT.AGGREGATE queries in cluster; ensure zero when idle.

^{Written by Cursor Bugbot for commit 8df8b83. This will update automatically on new commits. Configure here.}

imp tests

…hreads

expose ConcurrentSearchPool_WorkingThreadCount

cursor · 2025-11-27T04:55:02Z

tests/pytests/test_info_modules.py

    for i, con in enumerate(env.getOSSMasterNodesConnectionList()):
        info_dict = info_modules_to_dict(con)
-        env.assertEqual(info_dict[multi_threading_section][f'{SEARCH_PREFIX}active_worker_threads'], '0',
+        multi_threading_section = info_dict[f'{SEARCH_PREFIX}multi_threading']


Bug: Variable reassignment breaks dictionary key lookup in test

The variable multi_threading_section is initialized as a string key on line 1235, but gets reassigned to a dictionary value on line 1238 inside the loop. After the loop exits, multi_threading_section holds a dict rather than the string key. Later code at lines 1271, 1277, and 1293 uses info_dict[multi_threading_section] expecting it to be a string key, which will raise a TypeError: unhashable type: 'dict' since Python dicts cannot be used as dictionary keys.

Additional Locations (2)

tests/pytests/test_info_modules.py#L1270-L1271

tests/pytests/test_info_modules.py#L1276-L1277

assert is initizlied in GlobalStats_GetMultiThreadingStats

cursor · 2025-11-27T12:27:23Z

src/concurrent_ctx.c

+  // Assert we only have 1 pool
+  RS_LOG_ASSERT(array_len(threadpools_g) == 1, "assuming 1 ConcurrentSearch pool");
+  return redisearch_thpool_num_jobs_in_progress(threadpools_g[0]);
+}


Bug: Null pointer dereference when thread pool not initialized

The new ConcurrentSearchPool_WorkingThreadCount() function accesses threadpools_g[0] without checking if threadpools_g is NULL. The RS_LOG_ASSERT only fires in debug builds (when ENABLE_ASSERT is defined) and becomes a NOP in release builds. When threadpools_g is NULL, array_len() returns 0 safely, but then threadpools_g[0] causes undefined behavior. The new test ActiveIoThreadsMetric calls GlobalStats_GetMultiThreadingStats() which invokes this function, but the test doesn't initialize the concurrent search pool first, causing a crash.

Additional Locations (1)

tests/cpptests/coord_tests/test_cpp_io_runtime_ctx.cpp#L197-L198

meiravgri · 2025-11-30T16:09:21Z

/backport

redisearch-backport-pull-request · 2025-11-30T16:09:34Z

Backport failed for 2.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.8
git worktree add -d .worktree/backport-7546-to-2.8 origin/2.8
cd .worktree/backport-7546-to-2.8
git switch --create backport-7546-to-2.8
git cherry-pick -x b0fc4ea1ad8576fdf596fc2b36c7c835c9c99138

redisearch-backport-pull-request · 2025-11-30T16:09:35Z

Backport failed for 2.10, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.10
git worktree add -d .worktree/backport-7546-to-2.10 origin/2.10
cd .worktree/backport-7546-to-2.10
git switch --create backport-7546-to-2.10
git cherry-pick -x b0fc4ea1ad8576fdf596fc2b36c7c835c9c99138

redisearch-backport-pull-request · 2025-11-30T16:09:37Z

Backport failed for 8.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 8.2
git worktree add -d .worktree/backport-7546-to-8.2 origin/8.2
cd .worktree/backport-7546-to-8.2
git switch --create backport-7546-to-8.2
git cherry-pick -x b0fc4ea1ad8576fdf596fc2b36c7c835c9c99138

redisearch-backport-pull-request · 2025-11-30T16:09:38Z

Backport failed for 8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 8.4
git worktree add -d .worktree/backport-7546-to-8.4 origin/8.4
cd .worktree/backport-7546-to-8.4
git switch --create backport-7546-to-8.4
git cherry-pick -x b0fc4ea1ad8576fdf596fc2b36c7c835c9c99138

* Add multi-threading statistics tracking for active I/O threads * fix comment * add cpp test * fix spelling * address comment * remove unnecessary nre line * add "active_worker_threads" metric * fix comment imp tests * test cleanups * add test comne about the num queries and cleanups * fix declartion * remove coord threads * add active_coord_threads expose ConcurrentSearchPool_WorkingThreadCount * make the tests run... * add "active_worker_threads" metric * fix declartion * remove coord threads * make the tests run... * introduce workersThreadPool_isInitialized assert is initizlied in GlobalStats_GetMultiThreadingStats * cleanup * rename workersThreadPool_isCreated * introduce ConcurrentSearchPool_IsCreated * fix test * we dont need workers * remove ConcurrentSearchPool_IsCreated and workersThreadPool_isInitialized * fix merge (cherry picked from commit b0fc4ea)

[MOD-12694] [MOD-12069] Add active_coord_threads metric (#7546) * Add multi-threading statistics tracking for active I/O threads * fix comment * add cpp test * fix spelling * address comment * remove unnecessary nre line * add "active_worker_threads" metric * fix comment imp tests * test cleanups * add test comne about the num queries and cleanups * fix declartion * remove coord threads * add active_coord_threads expose ConcurrentSearchPool_WorkingThreadCount * make the tests run... * add "active_worker_threads" metric * fix declartion * remove coord threads * make the tests run... * introduce workersThreadPool_isInitialized assert is initizlied in GlobalStats_GetMultiThreadingStats * cleanup * rename workersThreadPool_isCreated * introduce ConcurrentSearchPool_IsCreated * fix test * we dont need workers * remove ConcurrentSearchPool_IsCreated and workersThreadPool_isInitialized * fix merge (cherry picked from commit b0fc4ea)

@alonre24

* fix: Avoid Rust cache contamination across platforms. (#7569) * [MOD-12170] Implement ASM State Machine on notifications (#7331) * first commit * fix: handle lock in two phases * inform ownership in regular command process handlers * fix: handle proper init * fix: use conditional variable * fix: add some comments * test: add test proving deadlock * fix: changes as per comments * fix: remove this locking from conn * remove code where certainity is not so high * fix potential issue * test: add first unit tests version * test: add proper testing with the value proposition * test: improve testing * alternative using auxiliary lock * simplify thpool a bit * make sure RedisModule_Yield is protected * fix: fix issue raised by cursor * fix: handle potential deadlock in drain also * fix: fix potential TOCTOU concurrency bug * fix: fix order of release * fix: fix potential overflow issue * fix tests * fix: fix counts in all variables * small refactor * some refactoring of Shared Exclusive Lock * simplify * protect GILOwned simple bool * clarify some comments * set GILAlternativeLockHeld to true properly * fix spelling * add assertion * fix: fix import RS_LOG_ASSERT * test: add more conditions to testing * add some more logic * improve testing to proper signal main thread can finish while other threads may be waiting for the Shared Lock in the loop * test: handl test properly * add another pattern of tests * fix comments from cursor * fix concurrency bug * fix: fix potential race condition at release lock time * fix: add condition * test: add more testing * force testing further to capture more potential errors * parametrize tests * test: make tests a little faster * test: add micro benchmark * fix compile microbenchmarks * fix: avoid potential reentrant deadlocks * fix: avoid potential reentrant deadlocks * test: avoid leak in test * test: avoid leak in test * fix: fix assertion * fix: fix assertion * Simplify Shared Lock internals (#7267) * simplify shared lock * small improvement to set_timeout * fix comment * fix nd improve comments * condition fix * remove lock type from release API * Add lock type back to the release API * remove Unlocked from enum and handle clock init for macOS * adapt to use new API * chnange according to comments * handle PR comments * handle PR comments * fix: take shared lock in other cases * change as PR comments * test: simplify test, do not allow query errors * fix tests as per comments * fix: handle number of high priority jobs running * fix: fix test comment * add ASM to help slot tracking in notifications * test: add some testing idea * change as per PR comments * compile and link test fix * change draining method to drain high priority * add ctests for ASM State Machine * test: add ASM tests * test: complete tests * change as per PR comments * add micro benchmarks with jobs in threads * remove changes not wanted * checkout redis feature branch in task test * remove draining * move atomic to new header * remove _internal naming * fix formatting --------- Co-authored-by: GuyAv46 <[email protected]> * [MOD-12627] Add Debug Support for `FT.PROFILE` Command (#7510) * imp debug profile for SA: introduce in mocule.h: RSProfileCommandImp RSProfileCommand calls RSProfileCommandImp(isDebug = false) for regular execution ProfileCommandCommand_DebugWrapper mcalls it with isDebug=true and skips _FT.DEBUG introduce entrypoint for _FT.DEBUG FT.PROFILE in debug_commands: ProfileCommandCommand_DebugWrapper RSProfileCommandImp calls DEBUG_execCommandCommon is its debug _recursiveProfilePrint skips printing debug RP * pass is debug instead of extracting: module.h: replace declaration: DistAggregateCommand DistSearchCommand with Imp version that receives isDebug expose ProfileCommandHandlerImp align debug_commands introducr _FT.DEBUG _FT.PROFILE * add test for cluster * return res * augi fixes * fix spell check * fix for real * fix test * skip tests according to env * revrt test_profile changes * reove changes from internal_only * [MOD-12694] [MOD-12069] Add active_coord_threads metric (#7546) * Add multi-threading statistics tracking for active I/O threads * fix comment * add cpp test * fix spelling * address comment * remove unnecessary nre line * add "active_worker_threads" metric * fix comment imp tests * test cleanups * add test comne about the num queries and cleanups * fix declartion * remove coord threads * add active_coord_threads expose ConcurrentSearchPool_WorkingThreadCount * make the tests run... * add "active_worker_threads" metric * fix declartion * remove coord threads * make the tests run... * introduce workersThreadPool_isInitialized assert is initizlied in GlobalStats_GetMultiThreadingStats * cleanup * rename workersThreadPool_isCreated * introduce ConcurrentSearchPool_IsCreated * fix test * we dont need workers * remove ConcurrentSearchPool_IsCreated and workersThreadPool_isInitialized * fix merge * [MOD-12789] test: fix flaky thpool test (#7581) test: fix flaky thpool test * Support Multiple Slot Ranges in search.CLUSTERSET - [MOD-11657] (#7508) * support multiple slot ranges * implement and move around helpers * add tests * ignore shards with no slots * improve parsing * better error message * fix flow tests * fix tests * sort by node id * improve error testing * cover missing cases * more error messages improvements * address AI review * stabilize Unexpected argument error path * stabilize more error paths * fix tests accordingly * last fix * add logs to cluster set command * add more logs per @alonre24 request * rename MetricIterator to Metric (#7586) The other iterators are not suffixed with 'Iterator'. * [MOD-12701] Split the execution of Rust and C/C++ unit tests across two different CI steps. (#7587) Split the execution of Rust and C/C++ unit tests across two different CI steps. * [MOD-12519] implement skip multi in II iterators (#7426) * remove it->skipMulti No longer needed as the full iterators have been removed. The query ones always set it to true. * implement skip multi II query iterators are supposed to skip results having the same ids. Test ported from test_cpp_iterator_index.cpp * inline read() and skip_to() * test more ii iterator edge cases Port of GetCorrectValue and EOFAfterFiltering from test_cpp_iterator_index.cpp * Compress layers prior to exporting them to the Docker layer cache (#7529) * Compress Docker layers prior to exporting them. * Ignore boost subfolders recursively * [MOD-12417] Track maxprefixexpansions errors and warnings in info (#7570) track maxprefixexpanions * [MOD-12409]: Port DocumentType enum to Rust (#7590) Port DocumentType enum to Rust Port DocumentType enum to Rust as `document::DocumentType`, removing it from `redisearch.h`. Use `document::DocumentType` in `rlookup` instead of `rlookup::bindings::DocumentType`. * [MOD-12069] Add `*_pending_jobs` metrics (#7556) * align info/* to active_coord * add APIs to get queues length * add to info * fix * test * fix test * catch general error * rename * fix moduleArgs * rename * rename test_active_worker_threads * rename to wworketrs * [MOD-12392] Remove numDocs parameter from non-optimized Wildcard iterator (#7602) Remove numDocs parameter from non-optimized Wildcard iterator * [MOD-12701] Enforce a per-test timeout in the C++ rstest suite using ctest (#7588) * Enforce a per-test timeout in the C++ rstest suite using ctest * Disable problematic tests * Raise timeout to 60s * Raise timeout * Add a timeout for coordinator tests too * Skip ActivateIoThreadsMetric test * Register Cursor Sub-Commands as such - [MOD-12807, MOD-12808] (#7571) * split cursor command * fix and improve tests * cover error cases * fix cursor leaks * Add "TODO: run hybrid cursor" back * remove new empty line * small test improvement * fix FT.CURSOR GC * de-flake test * make CURSOR PROFILE internal only * test the free * Keep just the prints * test on macos and noble as well * Move the free * Remove * Add to non container * Back to regular test * Remove spaces * Moved the remove and add the repo size * Moved it again * Move it to after repo build * Move print after repo build * test all * run the temp flow * add mount to container * Fix curly --------- Co-authored-by: Luca Palmieri <[email protected]> Co-authored-by: Joan Fontanals <[email protected]> Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: meiravgri <[email protected]> Co-authored-by: Guillaume Desmottes <[email protected]> Co-authored-by: lerman25 <[email protected]> Co-authored-by: Henk Oordt <[email protected]> Co-authored-by: alonre24 <[email protected]>

@alonre24

* Reduce merge queue * add ability to run manually * CR comments * allow workflow call for testing * Fix naming in build image + remove quick from flow intel as well * use ubuntu nobel rather than latest * fix noble typo * CR fixes * CR fixes 2 * don't use container for cov and san * restore leftover * remove mac + intel and workflow call * remove macos intel from matrix * change back ubuntu:latest to ubuntu:noble in merge-to-queue as per Jonathan comment * measure disk space * fix step name * Free disk on container (RediSearch#7613) * fix: Avoid Rust cache contamination across platforms. (RediSearch#7569) * [MOD-12170] Implement ASM State Machine on notifications (RediSearch#7331) * first commit * fix: handle lock in two phases * inform ownership in regular command process handlers * fix: handle proper init * fix: use conditional variable * fix: add some comments * test: add test proving deadlock * fix: changes as per comments * fix: remove this locking from conn * remove code where certainity is not so high * fix potential issue * test: add first unit tests version * test: add proper testing with the value proposition * test: improve testing * alternative using auxiliary lock * simplify thpool a bit * make sure RedisModule_Yield is protected * fix: fix issue raised by cursor * fix: handle potential deadlock in drain also * fix: fix potential TOCTOU concurrency bug * fix: fix order of release * fix: fix potential overflow issue * fix tests * fix: fix counts in all variables * small refactor * some refactoring of Shared Exclusive Lock * simplify * protect GILOwned simple bool * clarify some comments * set GILAlternativeLockHeld to true properly * fix spelling * add assertion * fix: fix import RS_LOG_ASSERT * test: add more conditions to testing * add some more logic * improve testing to proper signal main thread can finish while other threads may be waiting for the Shared Lock in the loop * test: handl test properly * add another pattern of tests * fix comments from cursor * fix concurrency bug * fix: fix potential race condition at release lock time * fix: add condition * test: add more testing * force testing further to capture more potential errors * parametrize tests * test: make tests a little faster * test: add micro benchmark * fix compile microbenchmarks * fix: avoid potential reentrant deadlocks * fix: avoid potential reentrant deadlocks * test: avoid leak in test * test: avoid leak in test * fix: fix assertion * fix: fix assertion * Simplify Shared Lock internals (RediSearch#7267) * simplify shared lock * small improvement to set_timeout * fix comment * fix nd improve comments * condition fix * remove lock type from release API * Add lock type back to the release API * remove Unlocked from enum and handle clock init for macOS * adapt to use new API * chnange according to comments * handle PR comments * handle PR comments * fix: take shared lock in other cases * change as PR comments * test: simplify test, do not allow query errors * fix tests as per comments * fix: handle number of high priority jobs running * fix: fix test comment * add ASM to help slot tracking in notifications * test: add some testing idea * change as per PR comments * compile and link test fix * change draining method to drain high priority * add ctests for ASM State Machine * test: add ASM tests * test: complete tests * change as per PR comments * add micro benchmarks with jobs in threads * remove changes not wanted * checkout redis feature branch in task test * remove draining * move atomic to new header * remove _internal naming * fix formatting --------- Co-authored-by: GuyAv46 <[email protected]> * [MOD-12627] Add Debug Support for `FT.PROFILE` Command (RediSearch#7510) * imp debug profile for SA: introduce in mocule.h: RSProfileCommandImp RSProfileCommand calls RSProfileCommandImp(isDebug = false) for regular execution ProfileCommandCommand_DebugWrapper mcalls it with isDebug=true and skips _FT.DEBUG introduce entrypoint for _FT.DEBUG FT.PROFILE in debug_commands: ProfileCommandCommand_DebugWrapper RSProfileCommandImp calls DEBUG_execCommandCommon is its debug _recursiveProfilePrint skips printing debug RP * pass is debug instead of extracting: module.h: replace declaration: DistAggregateCommand DistSearchCommand with Imp version that receives isDebug expose ProfileCommandHandlerImp align debug_commands introducr _FT.DEBUG _FT.PROFILE * add test for cluster * return res * augi fixes * fix spell check * fix for real * fix test * skip tests according to env * revrt test_profile changes * reove changes from internal_only * [MOD-12694] [MOD-12069] Add active_coord_threads metric (RediSearch#7546) * Add multi-threading statistics tracking for active I/O threads * fix comment * add cpp test * fix spelling * address comment * remove unnecessary nre line * add "active_worker_threads" metric * fix comment imp tests * test cleanups * add test comne about the num queries and cleanups * fix declartion * remove coord threads * add active_coord_threads expose ConcurrentSearchPool_WorkingThreadCount * make the tests run... * add "active_worker_threads" metric * fix declartion * remove coord threads * make the tests run... * introduce workersThreadPool_isInitialized assert is initizlied in GlobalStats_GetMultiThreadingStats * cleanup * rename workersThreadPool_isCreated * introduce ConcurrentSearchPool_IsCreated * fix test * we dont need workers * remove ConcurrentSearchPool_IsCreated and workersThreadPool_isInitialized * fix merge * [MOD-12789] test: fix flaky thpool test (RediSearch#7581) test: fix flaky thpool test * Support Multiple Slot Ranges in search.CLUSTERSET - [MOD-11657] (RediSearch#7508) * support multiple slot ranges * implement and move around helpers * add tests * ignore shards with no slots * improve parsing * better error message * fix flow tests * fix tests * sort by node id * improve error testing * cover missing cases * more error messages improvements * address AI review * stabilize Unexpected argument error path * stabilize more error paths * fix tests accordingly * last fix * add logs to cluster set command * add more logs per @alonre24 request * rename MetricIterator to Metric (RediSearch#7586) The other iterators are not suffixed with 'Iterator'. * [MOD-12701] Split the execution of Rust and C/C++ unit tests across two different CI steps. (RediSearch#7587) Split the execution of Rust and C/C++ unit tests across two different CI steps. * [MOD-12519] implement skip multi in II iterators (RediSearch#7426) * remove it->skipMulti No longer needed as the full iterators have been removed. The query ones always set it to true. * implement skip multi II query iterators are supposed to skip results having the same ids. Test ported from test_cpp_iterator_index.cpp * inline read() and skip_to() * test more ii iterator edge cases Port of GetCorrectValue and EOFAfterFiltering from test_cpp_iterator_index.cpp * Compress layers prior to exporting them to the Docker layer cache (RediSearch#7529) * Compress Docker layers prior to exporting them. * Ignore boost subfolders recursively * [MOD-12417] Track maxprefixexpansions errors and warnings in info (RediSearch#7570) track maxprefixexpanions * [MOD-12409]: Port DocumentType enum to Rust (RediSearch#7590) Port DocumentType enum to Rust Port DocumentType enum to Rust as `document::DocumentType`, removing it from `redisearch.h`. Use `document::DocumentType` in `rlookup` instead of `rlookup::bindings::DocumentType`. * [MOD-12069] Add `*_pending_jobs` metrics (RediSearch#7556) * align info/* to active_coord * add APIs to get queues length * add to info * fix * test * fix test * catch general error * rename * fix moduleArgs * rename * rename test_active_worker_threads * rename to wworketrs * [MOD-12392] Remove numDocs parameter from non-optimized Wildcard iterator (RediSearch#7602) Remove numDocs parameter from non-optimized Wildcard iterator * [MOD-12701] Enforce a per-test timeout in the C++ rstest suite using ctest (RediSearch#7588) * Enforce a per-test timeout in the C++ rstest suite using ctest * Disable problematic tests * Raise timeout to 60s * Raise timeout * Add a timeout for coordinator tests too * Skip ActivateIoThreadsMetric test * Register Cursor Sub-Commands as such - [MOD-12807, MOD-12808] (RediSearch#7571) * split cursor command * fix and improve tests * cover error cases * fix cursor leaks * Add "TODO: run hybrid cursor" back * remove new empty line * small test improvement * fix FT.CURSOR GC * de-flake test * make CURSOR PROFILE internal only * test the free * Keep just the prints * test on macos and noble as well * Move the free * Remove * Add to non container * Back to regular test * Remove spaces * Moved the remove and add the repo size * Moved it again * Move it to after repo build * Move print after repo build * test all * run the temp flow * add mount to container * Fix curly --------- Co-authored-by: Luca Palmieri <[email protected]> Co-authored-by: Joan Fontanals <[email protected]> Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: meiravgri <[email protected]> Co-authored-by: Guillaume Desmottes <[email protected]> Co-authored-by: lerman25 <[email protected]> Co-authored-by: Henk Oordt <[email protected]> Co-authored-by: alonre24 <[email protected]> * Revert "Free disk on container (RediSearch#7613)" This reverts commit 9c68740. * add free disk step * rename + remove temp test * remove leftover * better readability in container input Co-authored-by: GuyAv46 <[email protected]> * fix double defaults --------- Co-authored-by: dor-forer <[email protected]> Co-authored-by: Luca Palmieri <[email protected]> Co-authored-by: Joan Fontanals <[email protected]> Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: meiravgri <[email protected]> Co-authored-by: Guillaume Desmottes <[email protected]> Co-authored-by: lerman25 <[email protected]> Co-authored-by: Henk Oordt <[email protected]>

* Add multi-threading statistics tracking for active I/O threads * fix comment * add cpp test * fix spelling * address comment * remove unnecessary nre line * add "active_worker_threads" metric * fix comment imp tests * test cleanups * add test comne about the num queries and cleanups * fix declartion * remove coord threads * add active_coord_threads expose ConcurrentSearchPool_WorkingThreadCount * make the tests run... * add "active_worker_threads" metric * fix declartion * remove coord threads * make the tests run... * introduce workersThreadPool_isInitialized assert is initizlied in GlobalStats_GetMultiThreadingStats * cleanup * rename workersThreadPool_isCreated * introduce ConcurrentSearchPool_IsCreated * fix test * we dont need workers * remove ConcurrentSearchPool_IsCreated and workersThreadPool_isInitialized * fix merge (cherry picked from commit b0fc4ea)

* [MOD-12694] [MOD-12069] Add active_coord_threads metric (#7546) * Add multi-threading statistics tracking for active I/O threads * fix comment * add cpp test * fix spelling * address comment * remove unnecessary nre line * add "active_worker_threads" metric * fix comment imp tests * test cleanups * add test comne about the num queries and cleanups * fix declartion * remove coord threads * add active_coord_threads expose ConcurrentSearchPool_WorkingThreadCount * make the tests run... * add "active_worker_threads" metric * fix declartion * remove coord threads * make the tests run... * introduce workersThreadPool_isInitialized assert is initizlied in GlobalStats_GetMultiThreadingStats * cleanup * rename workersThreadPool_isCreated * introduce ConcurrentSearchPool_IsCreated * fix test * we dont need workers * remove ConcurrentSearchPool_IsCreated and workersThreadPool_isInitialized * fix merge (cherry picked from commit b0fc4ea) * gurad with RS_COORDINATOR * fix test * fix comment

meiravgri added 14 commits November 26, 2025 09:39

Add multi-threading statistics tracking for active I/O threads

4be59cb

fix comment

b60232c

add cpp test

aa681d5

fix spelling

7d079ad

address comment

ebe7871

remove unnecessary nre line

22ba007

add "active_worker_threads" metric

c8b0a6d

fix comment

190af73

imp tests

test cleanups

3780039

Merge branch 'meiravg_uv_active_thread_counter' into meiravg_active_t…

d1bd346

…hreads

add test comne about the num queries and cleanups

e3cd0c1

fix declartion

1bb3161

remove coord threads

ccba6ab

add active_coord_threads

1392b47

expose ConcurrentSearchPool_WorkingThreadCount

github-actions bot added the size:S label Nov 27, 2025

cursor bot reviewed Nov 27, 2025

View reviewed changes

meiravgri added 8 commits November 27, 2025 05:01

make the tests run...

f5b43cc

Merge branch 'meiravg_active_threads' into meiravg_coord_thread_metric

de74829

add "active_worker_threads" metric

41f2e1a

fix declartion

dc7e69d

remove coord threads

7d4733d

make the tests run...

acf5682

introduce workersThreadPool_isInitialized

53b2be3

assert is initizlied in GlobalStats_GetMultiThreadingStats

Merge remote-tracking branch 'origin/master' into meiravg_active_threads

be74191

meiravgri force-pushed the meiravg_active_threads branch from 161317e to be74191 Compare November 27, 2025 12:16

cleanup

9365a2a

cursor bot reviewed Nov 27, 2025

View reviewed changes

meiravgri added 3 commits November 27, 2025 12:35

rename workersThreadPool_isCreated

e60d90a

Merge branch 'meiravg_active_threads' into meiravg_coord_thread_metric

dbee480

introduce ConcurrentSearchPool_IsCreated

87de35b

JoanFM added this pull request to the merge queue Nov 28, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2025

meiravgri added this pull request to the merge queue Nov 29, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2025

meiravgri added this pull request to the merge queue Nov 29, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2025

meiravgri added this pull request to the merge queue Nov 30, 2025

Merged via the queue into master with commit b0fc4ea Nov 30, 2025
26 checks passed

meiravgri deleted the meiravg_coord_thread_metric branch November 30, 2025 07:11

meiravgri added backport 2.8 backport 2.10 backport 8.2 backport 8.4 labels Nov 30, 2025

meiravgri mentioned this pull request Nov 30, 2025

[MOD-12069] Add *_pending_jobs metrics #7556

Merged

This was referenced Dec 3, 2025

[8.4] [MOD-12694] [MOD-12069] Add active_coord_threads metric #7622

Merged

[8.2] [MOD-12694] [MOD-12069] Add active_coord_threads metric #7623

Merged

meiravgri mentioned this pull request Dec 7, 2025

[2.8] [MOD-12694] [MOD-12069] Add active_coord_threads metric #7665

Merged

meiravgri mentioned this pull request Dec 10, 2025

[2.10] [MOD-12694] [MOD-12069] Add active_coord_threads metric #7723

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MOD-12694] [MOD-12069] Add active_coord_threads metric#7546

[MOD-12694] [MOD-12069] Add active_coord_threads metric#7546
meiravgri merged 32 commits intomasterfrom
meiravg_coord_thread_metric

meiravgri commented Nov 27, 2025 •

edited by cursor bot

Loading

Uh oh!

cursor bot Nov 27, 2025

Uh oh!

cursor bot Nov 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

meiravgri commented Nov 30, 2025

Uh oh!

redisearch-backport-pull-request bot commented Nov 30, 2025

Uh oh!

redisearch-backport-pull-request bot commented Nov 30, 2025

Uh oh!

redisearch-backport-pull-request bot commented Nov 30, 2025

Uh oh!

redisearch-backport-pull-request bot commented Nov 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

meiravgri commented Nov 27, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

INFO MODULES Output

Uh oh!

cursor bot Nov 27, 2025

Choose a reason for hiding this comment

Bug: Variable reassignment breaks dictionary key lookup in test

Uh oh!

cursor bot Nov 27, 2025

Choose a reason for hiding this comment

Bug: Null pointer dereference when thread pool not initialized

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

meiravgri commented Nov 30, 2025

Uh oh!

redisearch-backport-pull-request bot commented Nov 30, 2025

Uh oh!

redisearch-backport-pull-request bot commented Nov 30, 2025

Uh oh!

redisearch-backport-pull-request bot commented Nov 30, 2025

Uh oh!

redisearch-backport-pull-request bot commented Nov 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

meiravgri commented Nov 27, 2025 •

edited by cursor bot

Loading